Attention is currently required from: Eric Lai, Subrata Banik, Sumeet R Pawnikar.
Tony Huang has posted comments on this change by Tony Huang. ( https://review.coreboot.org/c/coreboot/+/82434?usp=email )
Change subject: mb/google/rex/var/deku: Update DPTF parameters
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/rex/variants/deku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/82434/comment/bf2fccfe_40cd2a7f?usp... :
PS5, Line 22: # Temporary setting TCC of 105C = Tj max (110) - TCC_Offset (5)
: register "tcc_offset" = "5"
:
: register "power_limits_config[MTL_P_682_482_CORE]" = "{
: .tdp_pl1_override = 33,
: .tdp_pl2_override = 64,
: .tdp_pl4 = 120,
: }"
ideally i would expect to see these two changes separately […]
Hi Subrata,
Please hekp review. thanks
Set TCC_offset
https://review.coreboot.org/c/coreboot/+/82614
TDP override
https://review.coreboot.org/c/coreboot/+/82615
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82434?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I710682771bd0679ae4b44dd43be68f60e8984b2e
Gerrit-Change-Number: 82434
Gerrit-PatchSet: 6
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Thu, 23 May 2024 01:25:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com