Attention is currently required from: Kangheui Won, Maulik V Vaghela, Rizwan Qureshi, Subrata Banik, Sridhar Siricilla, Krishna P Bhat D, Usha P.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59937 )
Change subject: mb/intel/adlrvp: Configure GPIOs for Alder Lake-N
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/intel/adlrvp/gpio_n.c:
https://review.coreboot.org/c/coreboot/+/59937/comment/9831e62e_9702a9b8
PS5, Line 52: /*TCP1_DISP_AUX_P_BIAS_GPIO*/
: PAD_CFG_GPO(GPP_E20, 1, PLTRST),
: /*TCP1_DISP_AUX_N_BIAS_GPIO*/
: PAD_CFG_GPO(GPP_E21, 0, PLTRST),
: /*TCP0_DISP_AUX_P_BIAS_GPIO*/
: PAD_CFG_GPO(GPP_E22, 0, PLTRST),
: /*TCP0_DISP_AUX_N_BIAS_GPIO*/
: PAD_CFG_GPO(GPP_E23, 1, PLTRST),
I am guessing here from the pad names, but should these be NF6 for AUX BIAS functionality?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59937
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c0ca52d0cc73acfd8503007d5f3d2ad9a48f8ca
Gerrit-Change-Number: 59937
Gerrit-PatchSet: 6
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Comment-Date: Tue, 14 Dec 2021 20:55:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment