Attention is currently required from: Tim Wawrzynczak, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67489 )
Change subject: common/gma-registers: Update for Tiger Lake ......................................................................
Patch Set 1: Verified+1 Code-Review+1
(6 comments)
Patchset:
PS1: Great work! I left some comments but the numbers seem right so far :)
File common/hw-gfx-gma-registers.ads:
https://review.coreboot.org/c/libgfxinit/+/67489/comment/c9e38e70_01923099 PS1, Line 1787: GEN9_CHICKEN_DPCR_3 Linux calls it GEN9_CLKGATE_DIS_3, c/p error maybe?
https://review.coreboot.org/c/libgfxinit/+/67489/comment/2ba00596_a3088e1c PS1, Line 1987: HIP_INDEX_REG1 => 16#10_10a4# / Register_Width, Given that the indexed registers below are (almost?) grouped by the index they hide behind, can we comment the index above the groups?
https://review.coreboot.org/c/libgfxinit/+/67489/comment/69920d9c_ae9a8d06 PS1, Line 2030: COLD Isn't it COLD*ST*? That's what I see in Linux and (not sure if related yet) in the register reference.
https://review.coreboot.org/c/libgfxinit/+/67489/comment/8f268db8_bf960064 PS1, Line 2120: PLANE_COLOR_CTL_1_C => 16#07_21cc# / Register_Width, Isn't there a fourth pipe now?
https://review.coreboot.org/c/libgfxinit/+/67489/comment/7b420af0_8b911f7a PS1, Line 2134: PORT_TX_DFLEXDPPMS_FIA3 => 16#16_f890# / Register_Width, : PORT_TX_DFLEXDPMLE1_FIA3 => 16#16_f8c0# / Register_Width, These two lines are switched compared to the respective ones above. I assume they were supposed to be sorted by name? (numbers look right)
-
Nico Huber (Code Review)