Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38844 )
Change subject: mainboard/hatch/mainboard.c: Accommodate larger SKU id space
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38844/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38844/1//COMMIT_MSG@7
PS1, Line 7: mainboard/hatch: Change SKU_MAX to 0x7FFFFFFF
mainboard/hatch/mainboard. […]
Done
https://review.coreboot.org/c/coreboot/+/38844/1//COMMIT_MSG@9
PS1, Line 9: Default
This doesn't add anything that the code doesn't already say. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38844
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5a3f47989f596b838739becfb1da1bdaf16dd27
Gerrit-Change-Number: 38844
Gerrit-PatchSet: 2
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 12 Feb 2020 02:44:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment