Change in coreboot[master]: vc/amd/agesa/f14: Fix array length

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Jacob Garber (Code Review)

19 Feb 2020 19 Feb '20

8:02 p.m.

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39014 )

Change subject: vc/amd/agesa/f14: Fix array length ......................................................................

vc/amd/agesa/f14: Fix array length

This array is declared to have length MAX_FF_TYPES (aka 6) in several other places, so update it here so the length matches. This fixes a compiler error when using LTO. Extending the length is harmless, since the only code that uses this array will stop once it reaches the NULL pointer.

Change-Id: Ie00e969fa8cda88a934bf416c8775f7ae0b2747e Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M src/vendorcode/amd/agesa/f14/Config/OptionMemoryInstall.h 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/39014/1

diff --git a/src/vendorcode/amd/agesa/f14/Config/OptionMemoryInstall.h b/src/vendorcode/amd/agesa/f14/Config/OptionMemoryInstall.h index 57dc0c8..d75445b 100644 --- a/src/vendorcode/amd/agesa/f14/Config/OptionMemoryInstall.h +++ b/src/vendorcode/amd/agesa/f14/Config/OptionMemoryInstall.h @@ -569,7 +569,7 @@ #define PLAT_SP_ON_FF_SDIMM3 MemPConstructPsUDef, #define PLAT_SP_ON_FF_UDIMM3 MemPConstructPsUDef, #endif - MEM_PLAT_SPEC_CFG* memPlatSpecFFInstalledON[] = { + MEM_PLAT_SPEC_CFG* memPlatSpecFFInstalledON[MAX_FF_TYPES] = { PLAT_SP_ON_FF_SDIMM3 PLAT_SP_ON_FF_UDIMM3 NULL

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Paul Menzel (Code Review)

21 Feb 21 Feb

3:01 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39014 )

Change subject: vc/amd/agesa/f14: Fix array length ......................................................................

Patch Set 1: Code-Review+1

Paul Menzel (Code Review)

8 Mar 8 Mar

9:59 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39014 )

Change subject: vc/amd/agesa/f14: Fix array length ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39014/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39014/1//COMMIT_MSG@10 PS1, Line 10: This fixes a : compiler error when using LTO. Please cite the error.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie00e969fa8cda88a934bf416c8775f7ae0b2747e Gerrit-Change-Number: 39014 Gerrit-PatchSet: 1 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-Comment-Date: Sun, 08 Mar 2020 08:59:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

16 Apr 16 Apr

10:45 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39014 )

Change subject: vc/amd/agesa/f14: Fix array length ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie00e969fa8cda88a934bf416c8775f7ae0b2747e Gerrit-Change-Number: 39014 Gerrit-PatchSet: 1 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-Comment-Date: Thu, 16 Apr 2020 08:45:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Marshall Dawson (Code Review)

17 Apr 17 Apr

11:09 p.m.

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39014 )

Change subject: vc/amd/agesa/f14: Fix array length ......................................................................

Patch Set 2: Code-Review+2

I thought someone had already fixed this.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie00e969fa8cda88a934bf416c8775f7ae0b2747e Gerrit-Change-Number: 39014 Gerrit-PatchSet: 2 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-Comment-Date: Fri, 17 Apr 2020 21:09:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jacob Garber (Code Review)

18 Apr 18 Apr

8:54 p.m.

Hello build bot (Jenkins), Michał Żygowski, Marshall Dawson, Paul Menzel, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39014

to look at the new patch set (#3).

Change subject: vc/amd/agesa/f14: Fix array length ......................................................................

vc/amd/agesa/f14: Fix array length

This array is declared to have length MAX_FF_TYPES (aka 6) in several other places, so update it here so the length matches. This fixes a -Wlto-type-mismatch compiler error when using LTO. Extending the length is harmless, since the only code that uses this array will stop once it reaches the NULL pointer.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/39014/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/39014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie00e969fa8cda88a934bf416c8775f7ae0b2747e Gerrit-Change-Number: 39014 Gerrit-PatchSet: 3 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

8:56 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39014 )

Change subject: vc/amd/agesa/f14: Fix array length ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie00e969fa8cda88a934bf416c8775f7ae0b2747e Gerrit-Change-Number: 39014 Gerrit-PatchSet: 3 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-Comment-Date: Sat, 18 Apr 2020 18:56:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jacob Garber (Code Review)

8:58 p.m.

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39014 )

Change subject: vc/amd/agesa/f14: Fix array length ......................................................................

Patch Set 3:

(1 comment)

...

Patch Set 2: Code-Review+2

I thought someone had already fixed this.

You're probably thinking of this patch, it's been around for several months.

https://review.coreboot.org/c/coreboot/+/39014/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39014/1//COMMIT_MSG@10 PS1, Line 10: This fixes a : compiler error when using LTO.

...

Please cite the error.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/39014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie00e969fa8cda88a934bf416c8775f7ae0b2747e Gerrit-Change-Number: 39014 Gerrit-PatchSet: 3 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-Comment-Date: Sat, 18 Apr 2020 18:58:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Angel Pons (Code Review)

9:07 p.m.

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39014 )

Change subject: vc/amd/agesa/f14: Fix array length ......................................................................

vc/amd/agesa/f14: Fix array length

Change-Id: Ie00e969fa8cda88a934bf416c8775f7ae0b2747e Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/39014 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/amd/agesa/f14/Config/OptionMemoryInstall.h 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

diff --git a/src/vendorcode/amd/agesa/f14/Config/OptionMemoryInstall.h b/src/vendorcode/amd/agesa/f14/Config/OptionMemoryInstall.h index 231b263..600ae9b 100644 --- a/src/vendorcode/amd/agesa/f14/Config/OptionMemoryInstall.h +++ b/src/vendorcode/amd/agesa/f14/Config/OptionMemoryInstall.h @@ -569,7 +569,7 @@ #define PLAT_SP_ON_FF_SDIMM3 MemPConstructPsUDef, #define PLAT_SP_ON_FF_UDIMM3 MemPConstructPsUDef, #endif - MEM_PLAT_SPEC_CFG* memPlatSpecFFInstalledON[] = { + MEM_PLAT_SPEC_CFG* memPlatSpecFFInstalledON[MAX_FF_TYPES] = { PLAT_SP_ON_FF_SDIMM3 PLAT_SP_ON_FF_UDIMM3 NULL

-- To view, visit https://review.coreboot.org/c/coreboot/+/39014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie00e969fa8cda88a934bf416c8775f7ae0b2747e Gerrit-Change-Number: 39014 Gerrit-PatchSet: 4 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-MessageType: merged

1847

days inactive

1906

days old

coreboot-gerrit@coreboot.org

8 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Jacob Garber (Code Review)
Marshall Dawson (Code Review)
Paul Menzel (Code Review)