Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82666?usp=email )
Change subject: tree: Remove unused <string.h> ......................................................................
tree: Remove unused <string.h>
Change-Id: I9ed1a82fcd3fc29124ddc406592bd45dc84d4628 Signed-off-by: Elyes Haouas ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/82666 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Yu-Ping Wu yupingso@google.com Reviewed-by: Yidi Lin yidilin@google.com --- M src/arch/arm64/smbios.c M src/arch/riscv/include/vm.h M src/arch/x86/smbios.c M src/console/vsprintf.c M src/drivers/acpi/thermal_zone/thermal_zone.c M src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c M src/drivers/generic/gpio_keys/gpio_keys.c M src/drivers/i2c/generic/generic.c M src/drivers/i2c/gpiomux/bus/bus.c M src/drivers/i2c/gpiomux/mux/mux.c M src/drivers/i2c/hid/hid.c M src/drivers/i2c/sx9310/sx9310.c M src/drivers/i2c/sx9324/sx9324.c M src/drivers/i2c/sx9360/sx9360.c M src/drivers/intel/gma/acpi.c M src/drivers/intel/usb4/retimer/retimer.c M src/drivers/nxp/uwb/uwb.c M src/drivers/spi/acpi/acpi.c M src/drivers/uart/acpi/acpi.c M src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c M src/include/bootstate.h M src/include/rmodule.h M src/lib/smbios_defaults.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/poppy/variants/nami/mainboard.c M src/mainboard/google/poppy/variants/nautilus/mainboard.c M src/mainboard/google/poppy/variants/rammus/mainboard.c M src/mainboard/google/reef/mainboard.c M src/mainboard/intel/adlrvp/mainboard.c M src/mainboard/intel/avenuecity_crb/romstage.c M src/mainboard/intel/beechnutcity_crb/romstage.c M src/mainboard/intel/mtlrvp/mainboard.c M src/mainboard/intel/tglrvp/mainboard.c M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/pcengines/apu2/mainboard.c M src/mainboard/prodrive/atlas/mainboard.c M src/mainboard/prodrive/hermes/smbios.c M src/soc/mediatek/common/display.c 41 files changed, 12 insertions(+), 41 deletions(-)
Approvals: Yidi Lin: Looks good to me, approved build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved
diff --git a/src/arch/arm64/smbios.c b/src/arch/arm64/smbios.c index 8042057..a8d0523 100644 --- a/src/arch/arm64/smbios.c +++ b/src/arch/arm64/smbios.c @@ -6,7 +6,6 @@ #include <console/console.h> #include <smbios.h> #include <stdio.h> -#include <string.h>
static void smbios_processor_id(u32 *processor_id) { diff --git a/src/arch/riscv/include/vm.h b/src/arch/riscv/include/vm.h index c1894c7..9219f10 100644 --- a/src/arch/riscv/include/vm.h +++ b/src/arch/riscv/include/vm.h @@ -3,7 +3,6 @@ #ifndef _VM_H #define _VM_H
-#include <string.h> #include <stdint.h> #include <arch/encoding.h>
diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index f42de71..ef2c19a 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <string.h> #include <smbios.h> #include <console/console.h> #include <arch/cpu.h> diff --git a/src/console/vsprintf.c b/src/console/vsprintf.c index 4ffc677..086ed7c 100644 --- a/src/console/vsprintf.c +++ b/src/console/vsprintf.c @@ -2,7 +2,6 @@
#include <console/vtxprintf.h> #include <stdio.h> -#include <string.h>
struct vsnprintf_context { char *str_buf; diff --git a/src/drivers/acpi/thermal_zone/thermal_zone.c b/src/drivers/acpi/thermal_zone/thermal_zone.c index b1016cd..e491f75 100644 --- a/src/drivers/acpi/thermal_zone/thermal_zone.c +++ b/src/drivers/acpi/thermal_zone/thermal_zone.c @@ -7,7 +7,6 @@ #include <device/device.h> #include <stdio.h> #include <stdlib.h> -#include <string.h>
#include "chip.h"
diff --git a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c index 28377a1..5f43e4f 100644 --- a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c +++ b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c @@ -4,7 +4,7 @@ #include <acpi/acpigen.h> #include <device/device.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #include <console/console.h>
diff --git a/src/drivers/generic/gpio_keys/gpio_keys.c b/src/drivers/generic/gpio_keys/gpio_keys.c index 97a4e05..f5df0c4 100644 --- a/src/drivers/generic/gpio_keys/gpio_keys.c +++ b/src/drivers/generic/gpio_keys/gpio_keys.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <device/device.h> #include <stdio.h> -#include <string.h>
#include "chip.h"
diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index a3d8ef2..98c59e6 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -8,7 +8,7 @@ #include <device/device.h> #include <gpio.h> #include <stdio.h> -#include <string.h> + #include "chip.h"
#if CONFIG(HAVE_ACPI_TABLES) diff --git a/src/drivers/i2c/gpiomux/bus/bus.c b/src/drivers/i2c/gpiomux/bus/bus.c index 8efcf21..2e2d685 100644 --- a/src/drivers/i2c/gpiomux/bus/bus.c +++ b/src/drivers/i2c/gpiomux/bus/bus.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/device.h> #include <stdio.h> -#include <string.h>
#include "chip.h"
diff --git a/src/drivers/i2c/gpiomux/mux/mux.c b/src/drivers/i2c/gpiomux/mux/mux.c index a7dcd64..1e1ea45 100644 --- a/src/drivers/i2c/gpiomux/mux/mux.c +++ b/src/drivers/i2c/gpiomux/mux/mux.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/device.h> #include <stdio.h> -#include <string.h>
#include "chip.h"
diff --git a/src/drivers/i2c/hid/hid.c b/src/drivers/i2c/hid/hid.c index 06b31d1..c91b04a 100644 --- a/src/drivers/i2c/hid/hid.c +++ b/src/drivers/i2c/hid/hid.c @@ -5,7 +5,7 @@ #include <assert.h> #include <device/device.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #include <gpio.h> #include <console/console.h> diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c index a4bdb15..19eda30 100644 --- a/src/drivers/i2c/sx9310/sx9310.c +++ b/src/drivers/i2c/sx9310/sx9310.c @@ -6,7 +6,7 @@ #include <device/i2c_simple.h> #include <device/device.h> #include <stdio.h> -#include <string.h> + #include "chip.h"
#define I2C_SX9310_ACPI_ID "STH9310" diff --git a/src/drivers/i2c/sx9324/sx9324.c b/src/drivers/i2c/sx9324/sx9324.c index 041991e..f2753ea 100644 --- a/src/drivers/i2c/sx9324/sx9324.c +++ b/src/drivers/i2c/sx9324/sx9324.c @@ -6,7 +6,7 @@ #include <device/i2c_simple.h> #include <device/device.h> #include <stdio.h> -#include <string.h> + #include "chip.h"
#define I2C_SX9324_ACPI_ID "STH9324" diff --git a/src/drivers/i2c/sx9360/sx9360.c b/src/drivers/i2c/sx9360/sx9360.c index d72f28d..63180c7 100644 --- a/src/drivers/i2c/sx9360/sx9360.c +++ b/src/drivers/i2c/sx9360/sx9360.c @@ -6,7 +6,7 @@ #include <device/i2c_simple.h> #include <device/device.h> #include <stdio.h> -#include <string.h> + #include "chip.h"
#define I2C_SX9360_ACPI_ID "STH9360" diff --git a/src/drivers/intel/gma/acpi.c b/src/drivers/intel/gma/acpi.c index 534c0d8..9211100 100644 --- a/src/drivers/intel/gma/acpi.c +++ b/src/drivers/intel/gma/acpi.c @@ -2,7 +2,7 @@
#include <acpi/acpigen.h> #include <stdio.h> -#include <string.h> + #include "i915.h"
void diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c index 3c867d4..3769fc9 100644 --- a/src/drivers/intel/usb4/retimer/retimer.c +++ b/src/drivers/intel/usb4/retimer/retimer.c @@ -8,7 +8,7 @@ #include <drivers/usb/acpi/chip.h> #include <gpio.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #include "retimer.h"
diff --git a/src/drivers/nxp/uwb/uwb.c b/src/drivers/nxp/uwb/uwb.c index 3c4fac1..8a451c4 100644 --- a/src/drivers/nxp/uwb/uwb.c +++ b/src/drivers/nxp/uwb/uwb.c @@ -7,7 +7,7 @@ #include <device/spi.h> #include <spi-generic.h> #include <stdio.h> -#include <string.h> + #include "chip.h"
static int spi_acpi_get_bus(const struct device *dev) diff --git a/src/drivers/spi/acpi/acpi.c b/src/drivers/spi/acpi/acpi.c index 75d6dc9..6d92776 100644 --- a/src/drivers/spi/acpi/acpi.c +++ b/src/drivers/spi/acpi/acpi.c @@ -7,7 +7,7 @@ #include <device/spi.h> #include <spi-generic.h> #include <stdio.h> -#include <string.h> + #include "chip.h"
static int spi_acpi_get_bus(const struct device *dev) diff --git a/src/drivers/uart/acpi/acpi.c b/src/drivers/uart/acpi/acpi.c index 716d522..bfa50c6 100644 --- a/src/drivers/uart/acpi/acpi.c +++ b/src/drivers/uart/acpi/acpi.c @@ -4,7 +4,7 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <stdio.h> -#include <string.h> + #include "chip.h"
static bool uart_acpi_add_gpios_to_crs(struct drivers_uart_acpi_config *config) diff --git a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c index fc6b759..4fa32e6 100644 --- a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c +++ b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c @@ -6,7 +6,7 @@ #include <device/device.h> #include <device/path.h> #include <stdio.h> -#include <string.h> + #include "chip.h"
#define CROS_EC_I2C_TUNNEL_HID "GOOG0012" diff --git a/src/include/bootstate.h b/src/include/bootstate.h index 30231ce..ab055af 100644 --- a/src/include/bootstate.h +++ b/src/include/bootstate.h @@ -3,7 +3,6 @@ #define BOOTSTATE_H
#include <assert.h> -#include <string.h> #include <stddef.h> /* Only declare main() when in ramstage. */ #if ENV_RAMSTAGE diff --git a/src/include/rmodule.h b/src/include/rmodule.h index bf26ad0..72faecc 100644 --- a/src/include/rmodule.h +++ b/src/include/rmodule.h @@ -4,7 +4,6 @@
#include <stdint.h> #include <stddef.h> -#include <string.h> #include <commonlib/rmodule-defs.h>
enum { diff --git a/src/lib/smbios_defaults.c b/src/lib/smbios_defaults.c index 56bddab..0ad6442 100644 --- a/src/lib/smbios_defaults.c +++ b/src/lib/smbios_defaults.c @@ -4,7 +4,6 @@ #include <smbios.h> #include <stdint.h> #include <stdio.h> -#include <string.h>
/* this function will fill the corresponding locator */ __weak void smbios_fill_dimm_locator(const struct dimm_info *dimm, struct smbios_type17 *t) diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index 257a27f..795d96e 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -15,7 +15,6 @@ #include <soc/pci_devs.h> #include <soc/nhlt.h> #include <stdio.h> -#include <string.h> #include <timer.h>
#include <variant/gpio.h> diff --git a/src/mainboard/google/gru/sdram_configs.c b/src/mainboard/google/gru/sdram_configs.c index 971b671..02790b0 100644 --- a/src/mainboard/google/gru/sdram_configs.c +++ b/src/mainboard/google/gru/sdram_configs.c @@ -6,7 +6,6 @@ #include <gpio.h> #include <soc/sdram.h> #include <stdio.h> -#include <string.h> #include <types.h>
static const char *sdram_configs[] = { diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c index 1290b97..685414e 100644 --- a/src/mainboard/google/kahlee/mainboard.c +++ b/src/mainboard/google/kahlee/mainboard.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <amdblocks/acpi.h> -#include <string.h> #include <console/console.h> #include <device/device.h> #include <device/mmio.h> diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index bc70db5..22f8150 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -20,7 +20,6 @@ #include <soc/spm.h> #include <soc/usb.h> #include <stdio.h> -#include <string.h>
#include "gpio.h" #include "panel.h" diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index 172581f..7bdfb5e 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -14,7 +14,6 @@ #include <smbios.h> #include <soc/ramstage.h> #include <stdio.h> -#include <string.h> #include <variant/sku.h> #include <gpio.h> #include <delay.h> diff --git a/src/mainboard/google/poppy/variants/nautilus/mainboard.c b/src/mainboard/google/poppy/variants/nautilus/mainboard.c index d21acd6..b77513b 100644 --- a/src/mainboard/google/poppy/variants/nautilus/mainboard.c +++ b/src/mainboard/google/poppy/variants/nautilus/mainboard.c @@ -7,7 +7,6 @@ #include <device/pci_ops.h> #include <smbios.h> #include <stdio.h> -#include <string.h> #include <variant/sku.h>
#define R_PCH_OC_WDT_CTL 0x54 diff --git a/src/mainboard/google/poppy/variants/rammus/mainboard.c b/src/mainboard/google/poppy/variants/rammus/mainboard.c index e8c7e69..7eafebc 100644 --- a/src/mainboard/google/poppy/variants/rammus/mainboard.c +++ b/src/mainboard/google/poppy/variants/rammus/mainboard.c @@ -4,7 +4,6 @@ #include <ec/google/chromeec/ec.h> #include <smbios.h> #include <stdio.h> -#include <string.h> #include <sar.h>
#define SKU_UNKNOWN 0xFFFFFFFF diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c index 4b1b32d..964fc1c 100644 --- a/src/mainboard/google/reef/mainboard.c +++ b/src/mainboard/google/reef/mainboard.c @@ -11,7 +11,6 @@ #include <smbios.h> #include <soc/nhlt.h> #include <stdio.h> -#include <string.h> #include <variant/ec.h> #include <variant/gpio.h>
diff --git a/src/mainboard/intel/adlrvp/mainboard.c b/src/mainboard/intel/adlrvp/mainboard.c index f6321e8..c02cbf9 100644 --- a/src/mainboard/intel/adlrvp/mainboard.c +++ b/src/mainboard/intel/adlrvp/mainboard.c @@ -12,7 +12,6 @@ #include <soc/gpio.h> #include <stdint.h> #include <stdio.h> -#include <string.h>
#include "board_id.h"
diff --git a/src/mainboard/intel/avenuecity_crb/romstage.c b/src/mainboard/intel/avenuecity_crb/romstage.c index 9cd8ccc..f0e67af 100644 --- a/src/mainboard/intel/avenuecity_crb/romstage.c +++ b/src/mainboard/intel/avenuecity_crb/romstage.c @@ -9,7 +9,6 @@ #include <soc/ddr.h> #include <soc/iio.h> #include <soc/romstage.h> -#include <string.h>
#include "chip.h"
diff --git a/src/mainboard/intel/beechnutcity_crb/romstage.c b/src/mainboard/intel/beechnutcity_crb/romstage.c index 9cd8ccc..f0e67af 100644 --- a/src/mainboard/intel/beechnutcity_crb/romstage.c +++ b/src/mainboard/intel/beechnutcity_crb/romstage.c @@ -9,7 +9,6 @@ #include <soc/ddr.h> #include <soc/iio.h> #include <soc/romstage.h> -#include <string.h>
#include "chip.h"
diff --git a/src/mainboard/intel/mtlrvp/mainboard.c b/src/mainboard/intel/mtlrvp/mainboard.c index 85c2dd4..93cec47 100644 --- a/src/mainboard/intel/mtlrvp/mainboard.c +++ b/src/mainboard/intel/mtlrvp/mainboard.c @@ -9,7 +9,6 @@ #include <smbios.h> #include <stdint.h> #include <stdio.h> -#include <string.h>
const char *smbios_system_sku(void) { diff --git a/src/mainboard/intel/tglrvp/mainboard.c b/src/mainboard/intel/tglrvp/mainboard.c index 8f38ca2..b15f2c1 100644 --- a/src/mainboard/intel/tglrvp/mainboard.c +++ b/src/mainboard/intel/tglrvp/mainboard.c @@ -7,7 +7,6 @@ #include <soc/gpio.h> #include <smbios.h> #include <stdio.h> -#include <string.h>
const char *smbios_system_sku(void) { diff --git a/src/mainboard/kontron/986lcd-m/mainboard.c b/src/mainboard/kontron/986lcd-m/mainboard.c index 01815ed..bd50fc3 100644 --- a/src/mainboard/kontron/986lcd-m/mainboard.c +++ b/src/mainboard/kontron/986lcd-m/mainboard.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <string.h> #include <types.h> #include <device/device.h> #include <console/console.h> diff --git a/src/mainboard/pcengines/apu2/mainboard.c b/src/mainboard/pcengines/apu2/mainboard.c index b21c7ed..242ad9d 100644 --- a/src/mainboard/pcengines/apu2/mainboard.c +++ b/src/mainboard/pcengines/apu2/mainboard.c @@ -17,7 +17,6 @@ #include <superio/nuvoton/nct5104d/nct5104d.h> #include <smbios.h> #include <stdio.h> -#include <string.h> #include <AGESA.h> #include "gpio_ftns.h"
diff --git a/src/mainboard/prodrive/atlas/mainboard.c b/src/mainboard/prodrive/atlas/mainboard.c index a70bbae..8488836 100644 --- a/src/mainboard/prodrive/atlas/mainboard.c +++ b/src/mainboard/prodrive/atlas/mainboard.c @@ -6,7 +6,6 @@ #include <gpio.h> #include <smbios.h> #include <stdio.h> -#include <string.h> #include <types.h>
#include "gpio.h" diff --git a/src/mainboard/prodrive/hermes/smbios.c b/src/mainboard/prodrive/hermes/smbios.c index 9671555..2f2869a 100644 --- a/src/mainboard/prodrive/hermes/smbios.c +++ b/src/mainboard/prodrive/hermes/smbios.c @@ -2,7 +2,6 @@
#include <smbios.h> #include <stdio.h> -#include <string.h> #include <types.h>
#include "eeprom.h" diff --git a/src/soc/mediatek/common/display.c b/src/soc/mediatek/common/display.c index 0c23e49..a212805 100644 --- a/src/soc/mediatek/common/display.c +++ b/src/soc/mediatek/common/display.c @@ -11,7 +11,6 @@ #include <soc/dsi.h> #include <soc/mtcmos.h> #include <stdio.h> -#include <string.h>
static struct panel_serializable_data *get_mipi_cmd_from_cbfs(struct panel_description *desc) {
-
Elyes Haouas (Code Review)