Change in coreboot[master]: mb/google/drallion: Correct drallion HWID and add HWID for variants

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Mathew King (Code Review)

26 Aug 2019 26 Aug '19

5:37 p.m.

Mathew King has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35104 )

Change subject: mb/google/drallion: Correct drallion HWID and add HWID for variants ......................................................................

mb/google/drallion: Correct drallion HWID and add HWID for variants

The current HWID for drallion is reported as invalid by chrome, generate new valid HWID with the following command and taking last 4 digits.

`printf "%d\n" 0x$(crc32 <(echo -n '$1'))`

BUG=b:140013681

Change-Id: I410d37fc3f3372e9420d674b65f2c9a704b670f2 Signed-off-by: Mathew King mathewk@chromium.org --- M src/mainboard/google/drallion/Kconfig 1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/35104/1

diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index cff56a4..076d3e2 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -64,7 +64,10 @@ config GBB_HWID string depends on CHROMEOS - default "DRALLION TEST 3556" + default "ARCADA_CML TEST 4940" if BOARD_GOOGLE_ARCADA_CML + default "SARIEN_CML TEST 2073" if BOARD_GOOGLE_SARIEN_CML + default "DRALLION TEST 4932" if BOARD_GOOGLE_DRALLION +

config MAINBOARD_DIR string

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Mathew King (Code Review)

26 Aug 26 Aug

5:38 p.m.

Mathew King has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/35104 )

Change subject: mb/google/drallion: Correct drallion HWID and add HWID for variants ......................................................................

mb/google/drallion: Correct drallion HWID and add HWID for variants

The current HWID for drallion is reported as invalid by chrome, generate new valid HWID with the following command and taking last 4 digits.

`printf "%d\n" 0x$(crc32 <(echo -n '$1'))`

BUG=b:140013681

Change-Id: I410d37fc3f3372e9420d674b65f2c9a704b670f2 Signed-off-by: Mathew King mathewk@chromium.org --- M src/mainboard/google/drallion/Kconfig 1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/35104/2

Mathew King (Code Review)

5:38 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35104

to look at the new patch set (#3).

Change subject: mb/google/drallion: Correct drallion HWID and add HWID for variants ......................................................................

mb/google/drallion: Correct drallion HWID and add HWID for variants

The current HWID for drallion is reported as invalid by chrome, generate new valid HWID with the following command and taking last 4 digits.

`printf "%d\n" 0x$(crc32 <(echo -n '$1'))`

BUG=b:140013681

Change-Id: I410d37fc3f3372e9420d674b65f2c9a704b670f2 Signed-off-by: Mathew King mathewk@chromium.org --- M src/mainboard/google/drallion/Kconfig 1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/35104/3

Justin TerAvest (Code Review)

5:47 p.m.

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35104 )

Change subject: mb/google/drallion: Correct drallion HWID and add HWID for variants ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35104/3/src/mainboard/google/dralli... File src/mainboard/google/drallion/Kconfig:

https://review.coreboot.org/c/coreboot/+/35104/3/src/mainboard/google/dralli... PS3, Line 67: default "ARCADA_CML TEST 4940" if BOARD_GOOGLE_ARCADA_CML I'm not sure that it's legal to have "_" in the initial part of an hwid entry. Maybe, but I haven't audited all the users.

Should we come up with better names for those projects than what's listed?

-- To view, visit https://review.coreboot.org/c/coreboot/+/35104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I410d37fc3f3372e9420d674b65f2c9a704b670f2 Gerrit-Change-Number: 35104 Gerrit-PatchSet: 3 Gerrit-Owner: Mathew King mathewk@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Chiranjeevi Rapolu chiranjeevi.rapolu@intel.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 26 Aug 2019 20:47:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mathew King (Code Review)

6:57 p.m.

Hello Aaron Durbin, Justin TerAvest, build bot (Jenkins), Chiranjeevi Rapolu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35104

to look at the new patch set (#4).

Change subject: mb/google/drallion: Correct drallion HWID and add HWID for variants ......................................................................

mb/google/drallion: Correct drallion HWID and add HWID for variants

The current HWID for drallion is reported as invalid by chrome, generate new valid HWID with the following command and taking last 4 digits.

`printf "%d\n" 0x$(crc32 <(echo -n '$1'))`

BUG=b:140013681

Change-Id: I410d37fc3f3372e9420d674b65f2c9a704b670f2 Signed-off-by: Mathew King mathewk@chromium.org --- M src/mainboard/google/drallion/Kconfig 1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/35104/4

Mathew King (Code Review)

6:59 p.m.

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35104 )

Change subject: mb/google/drallion: Correct drallion HWID and add HWID for variants ......................................................................

Patch Set 4:

(1 comment)

...

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35104/3/src/mainboard/google/dralli... File src/mainboard/google/drallion/Kconfig:

https://review.coreboot.org/c/coreboot/+/35104/3/src/mainboard/google/dralli... PS3, Line 67: default "ARCADA_CML TEST 4940" if BOARD_GOOGLE_ARCADA_CML

...

I'm not sure that it's legal to have "_" in the initial part of an hwid entry. […]

I removed the underscore, these two are test boards so it should be fine.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I410d37fc3f3372e9420d674b65f2c9a704b670f2 Gerrit-Change-Number: 35104 Gerrit-PatchSet: 4 Gerrit-Owner: Mathew King mathewk@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Chiranjeevi Rapolu chiranjeevi.rapolu@intel.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 26 Aug 2019 21:59:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Justin TerAvest teravest@chromium.org Gerrit-MessageType: comment

Chiranjeevi Rapolu (Code Review)

7:51 p.m.

Chiranjeevi Rapolu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35104 )

Change subject: mb/google/drallion: Correct drallion HWID and add HWID for variants ......................................................................

Patch Set 4:

With this patch, malformed hardware ID no longer happens.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I410d37fc3f3372e9420d674b65f2c9a704b670f2 Gerrit-Change-Number: 35104 Gerrit-PatchSet: 4 Gerrit-Owner: Mathew King mathewk@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Chiranjeevi Rapolu chiranjeevi.rapolu@intel.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 26 Aug 2019 22:51:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Martin Roth (Code Review)

28 Aug 28 Aug

1:32 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35104 )

Change subject: mb/google/drallion: Correct drallion HWID and add HWID for variants ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I410d37fc3f3372e9420d674b65f2c9a704b670f2 Gerrit-Change-Number: 35104 Gerrit-PatchSet: 4 Gerrit-Owner: Mathew King mathewk@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Chiranjeevi Rapolu chiranjeevi.rapolu@intel.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 28 Aug 2019 16:32:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Mathew King (Code Review)

29 Aug 29 Aug

4:16 p.m.

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35104 )

Change subject: mb/google/drallion: Correct drallion HWID and add HWID for variants ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35104/3/src/mainboard/google/dralli... File src/mainboard/google/drallion/Kconfig:

https://review.coreboot.org/c/coreboot/+/35104/3/src/mainboard/google/dralli... PS3, Line 67: default "ARCADA_CML TEST 4940" if BOARD_GOOGLE_ARCADA_CML

...

I removed the underscore, these two are test boards so it should be fine.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/35104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I410d37fc3f3372e9420d674b65f2c9a704b670f2 Gerrit-Change-Number: 35104 Gerrit-PatchSet: 4 Gerrit-Owner: Mathew King mathewk@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Chiranjeevi Rapolu chiranjeevi.rapolu@intel.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 29 Aug 2019 19:16:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mathew King mathewk@chromium.org Comment-In-Reply-To: Justin TerAvest teravest@chromium.org Gerrit-MessageType: comment

Martin Roth (Code Review)

4:46 p.m.

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35104 )

Change subject: mb/google/drallion: Correct drallion HWID and add HWID for variants ......................................................................

mb/google/drallion: Correct drallion HWID and add HWID for variants

The current HWID for drallion is reported as invalid by chrome, generate new valid HWID with the following command and taking last 4 digits.

`printf "%d\n" 0x$(crc32 <(echo -n '$1'))`

BUG=b:140013681

Change-Id: I410d37fc3f3372e9420d674b65f2c9a704b670f2 Signed-off-by: Mathew King mathewk@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/35104 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/mainboard/google/drallion/Kconfig 1 file changed, 3 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved

diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index ffadd0c..a2ed3d8 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -61,7 +61,9 @@ config GBB_HWID string depends on CHROMEOS - default "DRALLION TEST 3556" + default "ARCADACML TEST 2699" if BOARD_GOOGLE_ARCADA_CML + default "SARIENCML TEST 3111" if BOARD_GOOGLE_SARIEN_CML + default "DRALLION TEST 4932" if BOARD_GOOGLE_DRALLION

config MAINBOARD_DIR string

-- To view, visit https://review.coreboot.org/c/coreboot/+/35104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I410d37fc3f3372e9420d674b65f2c9a704b670f2 Gerrit-Change-Number: 35104 Gerrit-PatchSet: 5 Gerrit-Owner: Mathew King mathewk@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Chiranjeevi Rapolu chiranjeevi.rapolu@intel.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1765

days inactive

1768

days old

coreboot-gerrit@coreboot.org

9 comments

4 participants

tags (0)

participants (4)

Chiranjeevi Rapolu (Code Review)
Justin TerAvest (Code Review)
Martin Roth (Code Review)
Mathew King (Code Review)