Attention is currently required from: Jakub Czapiga, Kapil Porwal, Pratikkumar V Prajapati, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75909?usp=email )
Change subject: soc/intel/meteorlake: Exclude CBMEM region from TME encryption
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS4:
Lets keep it separate, considering separate tests performed which is already detailed in commit message for both of these patches.
I don't see a point of having two CL (for same SOC) to enable configs which are interdependent. Assume those cls are landing separately and ended up adding into two different CPFE (by the builder) releases, then there would be one CPFE where CBMEM ranges (cbmem -c/-t, ramoops) are all encrypted and unable to access those range. The condition would be worse if ODM/OEM picked such CPFE for their SMT.
It would create unnecessarily trouble by the end of the day.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75909?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5d9fc3317ee4d3a0794692cea7a593c89db1e92
Gerrit-Change-Number: 75909
Gerrit-PatchSet: 8
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Pratikkumar Prajapati
pratikkumar.v.prajapati@intel.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Comment-Date: Tue, 01 Aug 2023 10:13:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-MessageType: comment