Change in coreboot[master]: util/cbmem: Add FlameGraph-compatible timestamps output - coreboot-gerrit

4 Mar 2022


      Attention is currently required from: Jakub Czapiga, Alex Levin, Julius Werner, Jan Dabros.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62474 )
Change subject: util/cbmem: Add FlameGraph-compatible timestamps output
......................................................................
Patch Set 4:
(1 comment)
File src/commonlib/include/commonlib/timestamp_serialized.h:
PS4: 
nit: I think this change could be split out by itself, also, if we're going to go with this mechanism in the future, does it make sense to automate creating the strings to represent the timestamp names, e.g. with X-macros or similar?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62474
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a4e20a267e9e0fbc6b3a4d6a2409b32ce8fca33
Gerrit-Change-Number: 62474
Gerrit-PatchSet: 4
Gerrit-Owner: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Alex Levin levinale@google.com
Gerrit-Reviewer: Jan Dabros jsd@semihalf.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga jacz@semihalf.com
Gerrit-Attention: Alex Levin levinale@google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Jan Dabros jsd@semihalf.com
Gerrit-Comment-Date: Fri, 04 Mar 2022 21:04:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment