build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27471 )
Change subject: soc/intel/braswell/ramstage.c: SoC D-1 revision reported as stepping ??. ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/27471/1/src/soc/intel/braswell/ramstage.c File src/soc/intel/braswell/ramstage.c:
https://review.coreboot.org/#/c/27471/1/src/soc/intel/braswell/ramstage.c@90 PS1, Line 90: if (attrs->revid >= RID_D_STEPPING_START) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/27471/1/src/soc/intel/braswell/ramstage.c@90 PS1, Line 90: if (attrs->revid >= RID_D_STEPPING_START) { suspect code indent for conditional statements (4, 16)
https://review.coreboot.org/#/c/27471/1/src/soc/intel/braswell/ramstage.c@93 PS1, Line 93: } else if (attrs->revid >= RID_C_STEPPING_START) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/27471/1/src/soc/intel/braswell/ramstage.c@93 PS1, Line 93: } else if (attrs->revid >= RID_C_STEPPING_START) { suspect code indent for conditional statements (4, 16)