Change in ...coreboot[master]: drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33453
Change subject: drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP ......................................................................
drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP
Rather than force the user to create the RW_MRC_CACHE FMAP region, simply select CACHE_MRC_SETTINGS so it's done automatically for them.
Signed-off-by: Matt DeVillier matt.devillier@puri.sm Change-Id: Iaa1da6015c1bfafe8ea81ca34ef8851f0c689487 --- M src/drivers/intel/fsp1_0/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/33453/1
diff --git a/src/drivers/intel/fsp1_0/Kconfig b/src/drivers/intel/fsp1_0/Kconfig index 361dd5e..df7617e 100644 --- a/src/drivers/intel/fsp1_0/Kconfig +++ b/src/drivers/intel/fsp1_0/Kconfig @@ -88,10 +88,10 @@ config MRC_CACHE_FMAP bool "Use MRC Cache in FMAP" depends on ENABLE_MRC_CACHE + select CACHE_MRC_SETTINGS default n help Use the region "RW_MRC_CACHE" in FMAP instead of "mrc.cache" in CBFS. - You must define a region in your FMAP named "RW_MRC_CACHE".
config MRC_CACHE_SIZE hex "Fast Boot Data Cache Size"
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33453 )
Change subject: drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/33453/1/src/drivers/intel/fsp1_0/Kconfig File src/drivers/intel/fsp1_0/Kconfig:
https://review.coreboot.org/#/c/33453/1/src/drivers/intel/fsp1_0/Kconfig@a94 PS1, Line 94: If a custom FMD file is provided, this kind of stays true.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33453 )
Change subject: drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33453/1/src/drivers/intel/fsp1_0/Kconfig File src/drivers/intel/fsp1_0/Kconfig:
https://review.coreboot.org/#/c/33453/1/src/drivers/intel/fsp1_0/Kconfig@a94 PS1, Line 94:
If a custom FMD file is provided, this kind of stays true.
rephrase as 'Your FMAP must contain a region named "RW_MRC_CACHE"'?
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33453 )
Change subject: drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33453 )
Change subject: drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33453/1/src/drivers/intel/fsp1_0/Kconfig File src/drivers/intel/fsp1_0/Kconfig:
https://review.coreboot.org/#/c/33453/1/src/drivers/intel/fsp1_0/Kconfig@a94 PS1, Line 94:
rephrase as 'Your FMAP must contain a region named "RW_MRC_CACHE"'?
Sounds good.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33453 )
Change subject: drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33453/1/src/drivers/intel/fsp1_0/Kconfig File src/drivers/intel/fsp1_0/Kconfig:
https://review.coreboot.org/#/c/33453/1/src/drivers/intel/fsp1_0/Kconfig@a94 PS1, Line 94:
Sounds good.
Done
Hello Frans Hendriks, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33453
to look at the new patch set (#2).
Change subject: drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP ......................................................................
drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP
Rather than force the user to create the RW_MRC_CACHE FMAP region, simply select CACHE_MRC_SETTINGS so it's done automatically for them.
Signed-off-by: Matt DeVillier matt.devillier@puri.sm Change-Id: Iaa1da6015c1bfafe8ea81ca34ef8851f0c689487 --- M src/drivers/intel/fsp1_0/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/33453/2
Hello Frans Hendriks, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33453
to look at the new patch set (#3).
Change subject: drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP ......................................................................
drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP
Rather than force the user to create the RW_MRC_CACHE FMAP region, simply select CACHE_MRC_SETTINGS so it's done automatically for them.
Signed-off-by: Matt DeVillier matt.devillier@puri.sm Change-Id: Iaa1da6015c1bfafe8ea81ca34ef8851f0c689487 --- M src/drivers/intel/fsp1_0/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/33453/3
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33453 )
Change subject: drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP ......................................................................
Patch Set 3: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33453 )
Change subject: drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP ......................................................................
drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP
Rather than force the user to create the RW_MRC_CACHE FMAP region, simply select CACHE_MRC_SETTINGS so it's done automatically for them.
Signed-off-by: Matt DeVillier matt.devillier@puri.sm Change-Id: Iaa1da6015c1bfafe8ea81ca34ef8851f0c689487 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33453 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/drivers/intel/fsp1_0/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/drivers/intel/fsp1_0/Kconfig b/src/drivers/intel/fsp1_0/Kconfig index 361dd5e..d72d331 100644 --- a/src/drivers/intel/fsp1_0/Kconfig +++ b/src/drivers/intel/fsp1_0/Kconfig @@ -88,10 +88,11 @@ config MRC_CACHE_FMAP bool "Use MRC Cache in FMAP" depends on ENABLE_MRC_CACHE + select CACHE_MRC_SETTINGS default n help Use the region "RW_MRC_CACHE" in FMAP instead of "mrc.cache" in CBFS. - You must define a region in your FMAP named "RW_MRC_CACHE". + Your FMAP must contain a region named "RW_MRC_CACHE".
config MRC_CACHE_SIZE hex "Fast Boot Data Cache Size"
-
Frans Hendriks (Code Review) -
Matt DeVillier (Code Review)
-
Nico Huber (Code Review)