Attention is currently required from: Derek Huang.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78146?usp=email )
Change subject: mb/google/dedede/var/boxy: Add wait for HPD function
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/dedede/mainboard.c:
https://review.coreboot.org/c/coreboot/+/78146/comment/451dd7aa_377181d7 :
PS3, Line 46: variant_display_init();
You need to declare this function in src/mainboard/google/dedede/variants/baseboard/include/baseboar […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78146?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I208fdf8234886b2ef43a4b972e6682892238e8e9
Gerrit-Change-Number: 78146
Gerrit-PatchSet: 4
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Comment-Date: Fri, 06 Oct 2023 07:54:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Derek Huang
derekhuang@google.com
Gerrit-MessageType: comment