Attention is currently required from: Paul Fagerburg. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54072 )
Change subject: tests: code coverage improvements ......................................................................
Patch Set 1:
(2 comments)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/54072/comment/e225fee7_dd7fc5db PS1, Line 180: ifeq ($(COV),1) I *think* that you should set COV to 1 if coverage-report-tests is present in the $(MAKECMDGOALS). COV=1 should be required only for a single unit-test. Use of coverage-report-tests indicates that user wants to generate coverage report so this target should not require additional "confirmation".
If you decide to change this, remember to change docs as well :)
https://review.coreboot.org/c/coreboot/+/54072/comment/5004a6d3_88bae360 PS1, Line 181: coverage-report-tests: clean-coverage-report-tests target might be useful. It may be an alias for clean-unit-tests.
-
Jakub Czapiga (Code Review)