Change in coreboot[master]: mb/google/kohaku: Set mmio_pl1_override value for tablet mode
Hello Seunghwan Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/35534
to review the following change.
Change subject: mb/google/kohaku: Set mmio_pl1_override value for tablet mode ......................................................................
mb/google/kohaku: Set mmio_pl1_override value for tablet mode
This change limits PL1 to 5W in tablet mode for kohaku.
BUG=b:138395625 BRANCH=none TEST=Verified PL1 is limited in tablet mode
Change-Id: I79bea32cf46ffa50f83af3905f85a471cb94b339 Signed-off-by: Seunghwan Kim sh_.kim@samsung.com --- M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/35534/1
diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index 8c7bb1f..9614ef8 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -1,6 +1,7 @@ chip soc/intel/cannonlake register "tdp_pl1_override" = "8" register "tdp_pl2_override" = "51" + register "mmio_pl1_override" = "5"
register "tcc_offset" = "35" # TCC of 65C
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35534 )
Change subject: mb/google/kohaku: Set mmio_pl1_override value for tablet mode ......................................................................
Patch Set 1: Code-Review+2
SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35534 )
Change subject: mb/google/kohaku: Set mmio_pl1_override value for tablet mode ......................................................................
Patch Set 1: Code-Review-1
Still need to discuss about how to implement separate PL1 setting for tablet mode.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35534 )
Change subject: mb/google/kohaku: Set mmio_pl1_override value for tablet mode ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35534/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35534/1//COMMIT_MSG@13 PS1, Line 13: Verified PL1 is limited How did you check this ? On kernel side on shell/terminal OR in coreboot log messages ? Please add more details here under TEST.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35534 )
Change subject: mb/google/kohaku: Set mmio_pl1_override value for tablet mode ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35534/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35534/1/src/mainboard/google/hatch/... PS1, Line 4: 5 how did you arrive to number as 5W ? and it's not clear from here that this value is only applicable for Tablet mode. Can we add some comment or more info here for Tablet mode settings.
SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35534 )
Change subject: mb/google/kohaku: Set mmio_pl1_override value for tablet mode ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35534/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35534/1/src/mainboard/google/hatch/... PS1, Line 4: 5
how did you arrive to number as 5W ? and it's not clear from here that this value is only applicable […]
The CLs for separate PL1 setting for tablet mode are pending now, waiting for Intel team's response about enabling advanced DPTF feature. https://partnerissuetracker.corp.google.com/issues/138395625
shkim has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35534 )
Change subject: mb/google/kohaku: Set mmio_pl1_override value for tablet mode ......................................................................
Abandoned
-
SH Kim (Code Review) -
Shelley Chen (Code Review)
-
shkim (Code Review)
-
Sumeet R Pawnikar (Code Review)