Attention is currently required from: Timofey Komarov, Felix Singer, Nico Huber, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52692 )
Change subject: soc/intel/skylake: Allow to use Amber Lake FSP ......................................................................
Patch Set 5:
(2 comments)
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/52692/comment/8eb4f312_7a66bdce PS5, Line 19: select SOC_INTEL_COMMON_SKYLAKE_BASE
You can also select SKYLAKE_SOC_PCH_H here.
Good point! When this was SOC_INTEL_AMBERLAKE, it also included actual Amber Lake parts, which are not PCH-H. But now that this is SOC_INTEL_SKYLAKE_LGA1151_V2, it is always paired with PCH-H (see help text)
https://review.coreboot.org/c/coreboot/+/52692/comment/64cf8458_489f2d67 PS5, Line 21: Intel chipsets with LGA1151v2 socket (e.g., B365, H310C, Z370) support Hmm, chipsets don't have a socket. How about:
Selected by mainboards with a LGA1151 v2 socket and a Z370, H310C or B365 PCH