Attention is currently required from: Aamir Bohra, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro.
Subrata Banik has posted comments on this change by Aamir Bohra. ( https://review.coreboot.org/c/coreboot/+/86599?usp=email )
Change subject: mb/google/brya: Add support to get sku ID
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
in that case, can you implement sku_id() inside cros_ec file itself so you don't need to implement per board basic ? and use some smart method to call into ADC PIN when CONFIG_SKUID_VIA_CHROMEEC vs CONFIG_SKUID_VIA_ADC_PIN.
IIUC, cros_ec hosts the ec<->host APIs, Since sku_id is specific to mainboards and allows to define mainboard specific SKU ID mechanisms, this can be implemented per board.
In any case, you need a better commit msg, the current code doesn't convey what you are trying to achieve
Agree, updated the commit, PTAL.
you can always push code into some common directory like vendor to implement a common API that works for CrOS specific implementation rather duplicating one api across different main boards.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86599?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie55a9d83871f41e191574e554fe7d287c1ee60bd
Gerrit-Change-Number: 86599
Gerrit-PatchSet: 3
Gerrit-Owner: Aamir Bohra
aamirbohra@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Aamir Bohra
aamirbohra@google.com
Gerrit-Comment-Date: Wed, 26 Feb 2025 18:09:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Aamir Bohra
aamirbohra@google.com