Attention is currently required from: Bao Zheng, Martin Roth, Marshall Dawson, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58764 )
Change subject: amdfwtool: Extract out-of-bounds check to a function and move
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/58764/comment/bec876c2_6c6049a2
PS2, Line 358: ASSERT_FW_ENTRY
since this is a function and not a macro, i'd use a lower case function name here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58764
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71117d1c817c0b6ddaea4ea47aea91672cc6d55a
Gerrit-Change-Number: 58764
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Thu, 04 Nov 2021 00:39:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment