Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Curtis Chen, Zhuohao Lee, Brandon Breitenstein.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57139 )
Change subject: mb/google/volteer: Create APIs for USB-C DP alternate mode support
......................................................................
Patch Set 10:
(1 comment)
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/57139/comment/a81106a5_dc764856
PS9, Line 296: WAIT_FOR_DISPLAYPORT_TIMEOUT
Yes, we have a draft idea at my 8/26 comment. […]
mainboard_tcss_wait_for_displayport() checks if any device is connected on the specified port first, if nothing is connected it returns immediately, it won't wait for DP device and HPD
So the worse case is 2 * WAIT_FOR_DISPLAYPORT_TIMEOUT = 2 seconds if port-0 and port-1 are connected to non-DP devices, and port-3 is connected to DP
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57139
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7e6dd952d3183ecb76de6d4887ee573ef89bb50
Gerrit-Change-Number: 57139
Gerrit-PatchSet: 10
Gerrit-Owner: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Curtis Chen
curtis.chen@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Curtis Chen
curtis.chen@intel.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Attention: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Comment-Date: Thu, 02 Sep 2021 09:33:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Curtis Chen
curtis.chen@intel.com
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Gerrit-MessageType: comment