Attention is currently required from: Chhao Chang, Jarried Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84025?usp=email )
Change subject: soc/mediatek/mt8196: Add unmask eint event for bootblock ......................................................................
Patch Set 17:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84025/comment/4077cc19_ac5a3507?usp... : PS17, Line 12: ' "
https://review.coreboot.org/c/coreboot/+/84025/comment/483d5011_9b60cfe9?usp... : PS17, Line 12: ' "
https://review.coreboot.org/c/coreboot/+/84025/comment/db67b42b_9c7d2a33?usp... : PS17, Line 16: 31709620 Wrong bug?
File src/soc/mediatek/common/include/soc/eint_event.h:
https://review.coreboot.org/c/coreboot/+/84025/comment/e00d8dca_694a9b4d?usp... : PS17, Line 17: struct eint_info { : uintptr_t base; : unsigned int eint_num; : };
It has nothing to do with the type of IC.
I uploaded CB:86033 to do the refactoring for you. Please take a look. Chhao, if that looks good to you, please rebase this onto that patch. You'll need to add src/soc/mediatek/mt8196/eint_event_info.c with content:
``` /* SPDX-License-Identifier: GPL-2.0-only OR MIT */
#include <soc/addressmap.h> #include <soc/eint_event.h>
const struct eint_event_info eint_event[] = { {EINT_E_BASE, 75}, {EINT_S_BASE, 29}, {EINT_W_BASE, 58}, {EINT_N_BASE, 47}, {EINT_C_BASE, 25}, {}, }; ```
File src/soc/mediatek/mt8196/bootblock.c:
https://review.coreboot.org/c/coreboot/+/84025/comment/d2632799_17c8f366?usp... : PS17, Line 9: #include <soc/eint_event.h> sort