Attention is currently required from: Martin Roth, Yu-hsuan Hsu, Karthik Ramasubramanian.
Patrick Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57611 )
Change subject: mb/google/guybrush/var/nipperkin: Add ALC5682I and MAX98360 support
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/guybrush/Kconfig:
https://review.coreboot.org/c/coreboot/+/57611/comment/ef8b108e_e6e01c2c
PS5, Line 45: select DRIVERS_GENERIC_MAX98357A
Nit: Things are added in alphabetical order. Please move it after line 16.
Done
File src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/57611/comment/c0d87349_d9ca88ce
PS4, Line 111: RTL5682
they will test ALC5682-VD and ALC5682-VS […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57611
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab9d11adb7cd08effa2a9b6a627832bd89cb3cb5
Gerrit-Change-Number: 57611
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Huang
patrick.huang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Yu-hsuan Hsu
yuhsuan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Yu-hsuan Hsu
yuhsuan@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 17 Sep 2021 10:44:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-hsuan Hsu
yuhsuan@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Patrick Huang
patrick.huang@amd.corp-partner.google.com
Gerrit-MessageType: comment