Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61836?usp=email )
Change subject: amdfwtool: Add options to support mainboard specific SPL table
......................................................................
Patch Set 4:
(1 comment)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/61836/comment/e9ab51b2_074f42fd :
PS4, Line 286: if (cb_config->have_mb_spl) {
: fw_type = AMD_FW_SPL;
: subprog = 0;
: } else {
: fw_type = AMD_FW_SKIP;
: }
this breaks the default !cb_config->have_mb_spl case. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61836?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I385b0fe13cb78a053c07127ec3ea1c61dc42c7e4
Gerrit-Change-Number: 61836
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Avinash Alevoor
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 09 Oct 2023 11:30:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment