Change in coreboot[master]: drivers/intel/fsp2_0: Integrate FirmwareVersionInfo.h

[Ronak Kanabar (Code Review)]

Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45905 )

Change subject: drivers/intel/fsp2_0: Integrate FirmwareVersionInfo.h
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45905/7/src/drivers/intel/fsp2_0/ha... 
File src/drivers/intel/fsp2_0/hand_off_block.c:

https://review.coreboot.org/c/coreboot/+/45905/7/src/drivers/intel/fsp2_0/ha... 
PS7, Line 217: #if CONFIG(DISPLAY_FSP_VERSION_INFO)
> just if/else will work as well without #if/#elif ?

https://review.coreboot.org/c/coreboot/+/45905/7/src/drivers/intel/fsp2_0/in...

in this we are using compile time checks(because both have some common definitions) to select headers if we use run time checks here some definitions will be missing and build will not pass.

example: if we are selecting DISPLAY_FSP_VERSION_INFO_2 than FIRMWARE_VERSION_INFO_HOB definition is missing. so we need to use compile time checks here.