Change in coreboot[master]: soc/intel/elkhartlake: add __weak to mainboard_get_dram_part_num()
Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45871 )
Change subject: soc/intel/elkhartlake: add __weak to mainboard_get_dram_part_num() ......................................................................
soc/intel/elkhartlake: add __weak to mainboard_get_dram_part_num()
Add missing __weak declaration to Elkhart Lake's definition of mainboard_get_dram_part_num().
BUG=b:168724473 TEST=none
Change-Id: I883d662315a9ab91eb6183ebcdfd7e7cc8064c64 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/soc/intel/elkhartlake/romstage/romstage.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/45871/1
diff --git a/src/soc/intel/elkhartlake/romstage/romstage.c b/src/soc/intel/elkhartlake/romstage/romstage.c index d68d2da..09b1744 100644 --- a/src/soc/intel/elkhartlake/romstage/romstage.c +++ b/src/soc/intel/elkhartlake/romstage/romstage.c @@ -21,7 +21,7 @@ 0x8d, 0x09, 0x11, 0xcf, 0x8b, 0x9f, 0x03, 0x23 \ }
-bool mainboard_get_dram_part_num(const char **part_num, size_t *len) +bool __weak mainboard_get_dram_part_num(const char **part_num, size_t *len) { /* Default implementation, no need to override part number. */ return false;
Hello build bot (Jenkins), Furquan Shaikh, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45871
to look at the new patch set (#2).
Change subject: soc/intel/elkhartlake: add __weak to mainboard_get_dram_part_num() ......................................................................
soc/intel/elkhartlake: add __weak to mainboard_get_dram_part_num()
Add missing __weak declaration to Elkhart Lake's definition of mainboard_get_dram_part_num().
BUG=b:168724473 TEST=none
Change-Id: I883d662315a9ab91eb6183ebcdfd7e7cc8064c64 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/soc/intel/elkhartlake/romstage/romstage.c M src/soc/intel/jasperlake/romstage/romstage.c 2 files changed, 11 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/45871/2
Hello build bot (Jenkins), Furquan Shaikh, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45871
to look at the new patch set (#3).
Change subject: soc/intel/elkhartlake: add __weak to mainboard_get_dram_part_num() ......................................................................
soc/intel/elkhartlake: add __weak to mainboard_get_dram_part_num()
Add missing __weak declaration to Elkhart Lake's definition of mainboard_get_dram_part_num().
BUG=b:168724473 TEST=none
Change-Id: I883d662315a9ab91eb6183ebcdfd7e7cc8064c64 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/soc/intel/elkhartlake/romstage/romstage.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/45871/3
Hello build bot (Jenkins), Furquan Shaikh, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45871
to look at the new patch set (#4).
Change subject: soc/intel/elkhartlake: add __weak to mainboard_get_dram_part_num() ......................................................................
soc/intel/elkhartlake: add __weak to mainboard_get_dram_part_num()
Add missing __weak declaration to Elkhart Lake's definition of mainboard_get_dram_part_num().
BUG=b:169774482, b:168724473 TEST=none
Change-Id: I883d662315a9ab91eb6183ebcdfd7e7cc8064c64 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/soc/intel/elkhartlake/romstage/romstage.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/45871/4
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45871 )
Change subject: soc/intel/elkhartlake: add __weak to mainboard_get_dram_part_num() ......................................................................
Patch Set 4: Code-Review+2
Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45871 )
Change subject: soc/intel/elkhartlake: add __weak to mainboard_get_dram_part_num() ......................................................................
soc/intel/elkhartlake: add __weak to mainboard_get_dram_part_num()
Add missing __weak declaration to Elkhart Lake's definition of mainboard_get_dram_part_num().
BUG=b:169774482, b:168724473 TEST=none
Change-Id: I883d662315a9ab91eb6183ebcdfd7e7cc8064c64 Signed-off-by: Nick Vaccaro nvaccaro@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45871 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/elkhartlake/romstage/romstage.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/intel/elkhartlake/romstage/romstage.c b/src/soc/intel/elkhartlake/romstage/romstage.c index d68d2da..09b1744 100644 --- a/src/soc/intel/elkhartlake/romstage/romstage.c +++ b/src/soc/intel/elkhartlake/romstage/romstage.c @@ -21,7 +21,7 @@ 0x8d, 0x09, 0x11, 0xcf, 0x8b, 0x9f, 0x03, 0x23 \ }
-bool mainboard_get_dram_part_num(const char **part_num, size_t *len) +bool __weak mainboard_get_dram_part_num(const char **part_num, size_t *len) { /* Default implementation, no need to override part number. */ return false;
-
Furquan Shaikh (Code Review) -
Nick Vaccaro (Code Review)