Attention is currently required from: Nico Huber, Martin Roth, Felix Held. Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Frans Hendriks, David Hendricks, Paul Menzel, Angel Pons, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51838
to look at the new patch set (#3).
Change subject: lint: checkpatch: Add SUSPICIOUS_CODE_INDENT test ......................................................................
lint: checkpatch: Add SUSPICIOUS_CODE_INDENT test
This patch adds a new test to checkpatch that identifies cases where a line after a conditional statement is incorrectly intended (possibly indicating the mistake of forgetting to add braces), like this:
if (a) b; c;
Unfortunately, it seems like checkpatch is partially unmaintained in upstream Linux at the moment with maintainers either not responding at all or not even willing to look at new patches [1]. Since detecting this error class is important to coreboot, let's just carry this feature locally for now.
[1] https://lkml.org/lkml/2021/4/15/1488
Signed-off-by: Julius Werner jwerner@chromium.org Change-Id: I7bb90b56dfc7582271d2b82cb42a2c1df477054f --- M util/lint/checkpatch.pl 1 file changed, 56 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/51838/3