Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons.
Utkarsh Verma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74128 )
Change subject: arch/x86/smbios: Avoid buffer overflows ......................................................................
Patch Set 4:
(2 comments)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/74128/comment/99918c27_76959046 PS4, Line 148: char string_buffer[15];
Thanks for pointing out the buffer size, will fix it in the next patch. […]
Wait, I just checked it again. Shouldn't 15 buffer size be enough?
Format string -> 11 chars with '\0' Hex number -> 4 chars
https://review.coreboot.org/c/coreboot/+/74128/comment/ee9573af_843ba650 PS4, Line 552: static unsigned short cnt = 0;
Oh, this is a nice practical concept I didn't know. Thanks for the reference link. […]
Shouldn't have marked it as resolved, so just leaving this here. Please let me know if what I've suggested is okay or not.
-
Utkarsh Verma (Code Review)