[S] Change in coreboot[master]: device/pciexp_device.c: Do not enable common clock if already active - coreboot-gerrit

1 Mar 2023


      Attention is currently required from: Subrata Banik, Paul Menzel.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73310 )
Change subject: device/pciexp_device.c: Do not enable common clock if already active
......................................................................
Patch Set 1:
(1 comment)
File src/device/pciexp_device.c:
https://review.coreboot.org/c/coreboot/+/73310/comment/2b150ac6_4dc11ed5 
PS1, Line 205: 		printk(BIOS_INFO, "Common Clock Configuration already enabled\n");
...
You mean move the CCC detection into a helper function? Since the CCC enablement is a helper functio […]
Hey Subrata, any response to my question from your side?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/73310
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I747fa406a120a215de189d7252f160c8ea2e3716
Gerrit-Change-Number: 73310
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 01 Mar 2023 07:30:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Comment-In-Reply-To: Werner Zeh werner.zeh@siemens.com
Gerrit-MessageType: comment