Change in coreboot[master]: mb/google/puff/var/dooly: Update devicetree for audio configuration
Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46289 )
Change subject: mb/google/puff/var/dooly: Update devicetree for audio configuration ......................................................................
mb/google/puff/var/dooly: Update devicetree for audio configuration
1. Add speaker amplifier ALC1015
2. Enable dmic+ssp registers for speaker and camera DMIC
BUG=b:170273526 BRANCH=puff TEST=Build and check DUT function status
Change-Id: I5f6f19b40c6fcce8dca9b010ae97ea6e3eeb1473 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/dooly/overridetree.cb 1 file changed, 21 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/46289/1
diff --git a/src/mainboard/google/hatch/variants/dooly/overridetree.cb b/src/mainboard/google/hatch/variants/dooly/overridetree.cb index 21bbc3c..ee91dd3 100644 --- a/src/mainboard/google/hatch/variants/dooly/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dooly/overridetree.cb @@ -105,10 +105,6 @@ # [6:0] Rx Strobe Delay DLL 2(HS400 Mode), each 125ps, range: 0 - 39. register "common_soc_config.emmc_dll.emmc_rx_strobe_cntl" = "0x1515"
- # Intel HDA - disable I2S Audio SSP1 and DMIC0 as puff variant does not have them. - register "PchHdaAudioLinkSsp1" = "0" - register "PchHdaAudioLinkDmic0" = "0" - # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | @@ -117,10 +113,10 @@ #| | required to set up a BAR | #| | for TPM communication | #| | before memory is up | - #| I2C0 | RFU | - #| I2C2 | PS175 | - #| I2C3 | MST | - #| I2C4 | Audio | + #| I2C0 | ALC 1015 | + #| I2C2 | Lvds | + #| I2C3 | Touchscreen | + #| I2C4 | RT5682 | #+-------------------+---------------------------+ register "common_soc_config" = "{ .gspi[0] = { @@ -299,27 +295,24 @@ end end # USB xHCI device pci 14.5 off end # SDCard - device pci 15.0 off - # RFU - Reserved for Future Use. - end # I2C #0 + device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""10EC1015"" + register "desc" = ""Realtek SPK AMP L"" + register "uid" = "0" + device i2c 28 on end + end + chip drivers/i2c/generic + register "hid" = ""10EC1015"" + register "desc" = ""Realtek SPK AMP R"" + register "uid" = "1" + device i2c 29 on end + end + end # I2C #0 ALC1015 device pci 15.1 off end # I2C #1 - device pci 15.2 on - chip drivers/i2c/generic - register "hid" = ""1AF80175"" - register "name" = ""PS17"" - register "desc" = ""Parade PS175"" - device i2c 4a on end - end - end # I2C #2, PCON PS175. - device pci 15.3 on - chip drivers/i2c/generic - register "hid" = ""10EC2142"" - register "name" = ""RTD2"" - register "desc" = ""Realtek RTD2142"" - device i2c 4a on end - end - end # I2C #3, Realtek RTD2142. - device pci 16.0 on end # Management Engine Interface 1 + device pci 15.2 on end # I2C #2 LVDS + device pci 15.3 on end # I2C #3 Touchscreen + device pci 16.0 on end # Management Engine Interface 1 device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682""
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46289 )
Change subject: mb/google/puff/var/dooly: Update devicetree for audio configuration ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46289/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46289/1//COMMIT_MSG@7 PS1, Line 7: mb/google/puff/var/dooly: Update devicetree for audio configuration this is also updating for the display as well. You can update the commit msg or preferably split that out into another commit.
Hello Sam McNally, build bot (Jenkins), Edward O'Callaghan, Wisley Chen, Keith Tzeng,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46289
to look at the new patch set (#2).
Change subject: mb/google/puff/var/dooly: Update devicetree for audio configuration ......................................................................
mb/google/puff/var/dooly: Update devicetree for audio configuration
1. Add speaker amplifier ALC1015
2. Enable dmic+ssp registers for speaker and camera DMIC
3. Correct I2C#2 to LVDS, I2C#3 to Touchscreen
BUG=b:170273526 BRANCH=puff TEST=Build and check DUT function status
Change-Id: I5f6f19b40c6fcce8dca9b010ae97ea6e3eeb1473 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/dooly/overridetree.cb 1 file changed, 21 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/46289/2
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46289 )
Change subject: mb/google/puff/var/dooly: Update devicetree for audio configuration ......................................................................
Patch Set 2:
Hi Edward, Update commit message to include the display change, please help review. Thanks
Hello Sam McNally, build bot (Jenkins), Edward O'Callaghan, Wisley Chen, Keith Tzeng,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46289
to look at the new patch set (#3).
Change subject: mb/google/puff/var/dooly: Update devicetree for audio and display configuration ......................................................................
mb/google/puff/var/dooly: Update devicetree for audio and display configuration
1. Add speaker amplifier ALC1015
2. Enable dmic+ssp registers for speaker and camera DMIC
3. Correct I2C#2 to LVDS, I2C#3 to Touchscreen
BUG=b:170273526 BRANCH=puff TEST=Build and check DUT function status
Change-Id: I5f6f19b40c6fcce8dca9b010ae97ea6e3eeb1473 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/dooly/overridetree.cb 1 file changed, 21 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/46289/3
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46289 )
Change subject: mb/google/puff/var/dooly: Update devicetree for audio and display configuration ......................................................................
Patch Set 3: Code-Review+2
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46289 )
Change subject: mb/google/puff/var/dooly: Update devicetree for audio and display configuration ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46289/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46289/1//COMMIT_MSG@7 PS1, Line 7: mb/google/puff/var/dooly: Update devicetree for audio configuration
this is also updating for the display as well. […]
Done
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46289 )
Change subject: mb/google/puff/var/dooly: Update devicetree for audio and display configuration ......................................................................
mb/google/puff/var/dooly: Update devicetree for audio and display configuration
1. Add speaker amplifier ALC1015
2. Enable dmic+ssp registers for speaker and camera DMIC
3. Correct I2C#2 to LVDS, I2C#3 to Touchscreen
BUG=b:170273526 BRANCH=puff TEST=Build and check DUT function status
Change-Id: I5f6f19b40c6fcce8dca9b010ae97ea6e3eeb1473 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46289 Reviewed-by: Edward O'Callaghan quasisec@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/dooly/overridetree.cb 1 file changed, 21 insertions(+), 28 deletions(-)
Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/dooly/overridetree.cb b/src/mainboard/google/hatch/variants/dooly/overridetree.cb index 21bbc3c..ee91dd3 100644 --- a/src/mainboard/google/hatch/variants/dooly/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dooly/overridetree.cb @@ -105,10 +105,6 @@ # [6:0] Rx Strobe Delay DLL 2(HS400 Mode), each 125ps, range: 0 - 39. register "common_soc_config.emmc_dll.emmc_rx_strobe_cntl" = "0x1515"
- # Intel HDA - disable I2S Audio SSP1 and DMIC0 as puff variant does not have them. - register "PchHdaAudioLinkSsp1" = "0" - register "PchHdaAudioLinkDmic0" = "0" - # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | @@ -117,10 +113,10 @@ #| | required to set up a BAR | #| | for TPM communication | #| | before memory is up | - #| I2C0 | RFU | - #| I2C2 | PS175 | - #| I2C3 | MST | - #| I2C4 | Audio | + #| I2C0 | ALC 1015 | + #| I2C2 | Lvds | + #| I2C3 | Touchscreen | + #| I2C4 | RT5682 | #+-------------------+---------------------------+ register "common_soc_config" = "{ .gspi[0] = { @@ -299,27 +295,24 @@ end end # USB xHCI device pci 14.5 off end # SDCard - device pci 15.0 off - # RFU - Reserved for Future Use. - end # I2C #0 + device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""10EC1015"" + register "desc" = ""Realtek SPK AMP L"" + register "uid" = "0" + device i2c 28 on end + end + chip drivers/i2c/generic + register "hid" = ""10EC1015"" + register "desc" = ""Realtek SPK AMP R"" + register "uid" = "1" + device i2c 29 on end + end + end # I2C #0 ALC1015 device pci 15.1 off end # I2C #1 - device pci 15.2 on - chip drivers/i2c/generic - register "hid" = ""1AF80175"" - register "name" = ""PS17"" - register "desc" = ""Parade PS175"" - device i2c 4a on end - end - end # I2C #2, PCON PS175. - device pci 15.3 on - chip drivers/i2c/generic - register "hid" = ""10EC2142"" - register "name" = ""RTD2"" - register "desc" = ""Realtek RTD2142"" - device i2c 4a on end - end - end # I2C #3, Realtek RTD2142. - device pci 16.0 on end # Management Engine Interface 1 + device pci 15.2 on end # I2C #2 LVDS + device pci 15.3 on end # I2C #3 Touchscreen + device pci 16.0 on end # Management Engine Interface 1 device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682""
-
Edward O'Callaghan (Code Review) -
Tony Huang (Code Review)