Attention is currently required from: Hung-Te Lin, Paul Menzel, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57324 )
Change subject: drivers/mipi: Make orientation a property of the mainboard, not the panel
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57324/comment/5581a697_88be5481
PS3, Line 7: drivers/mipi: Make orientation a property of the mainboard, not the panel
Line too long
File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/57324/comment/55d895df_09d806c3
PS3, Line 144: panel
Just a note that by removing 'static' from edp_panel, we need to make sure this pointer won't be referenced outside this function.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57324
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2b716aa4dae036515730c12961fdd8a9ac34753
Gerrit-Change-Number: 57324
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 01 Sep 2021 23:57:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment