Attention is currently required from: Tim Wawrzynczak, Robert Chen, Nick Vaccaro, Shon Wang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60331 )
Change subject: mb/google/brya/var/vell: Add AMP driver setting
......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60331/comment/6d09ed26_ff6d5c0b
PS7, Line 9: update overridetree.cb
: update Kconfig.name
: update i2c/C35l53
Please make it a list.
Patchset:
PS7:
Please split this into to commits. The first adding the driver, the second hooking it up to the board.
File src/drivers/i2c/cs35l53/chip.h:
https://review.coreboot.org/c/coreboot/+/60331/comment/8f90c659_b43c930c
PS7, Line 132:
Blank line not needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c
Gerrit-Change-Number: 60331
Gerrit-PatchSet: 7
Gerrit-Owner: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 03 Jan 2022 08:00:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment