Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46754 )
Change subject: soc/intel/broadwell: Relocate PCH ACPI files ......................................................................
soc/intel/broadwell: Relocate PCH ACPI files
Tested with BUILD_TIMELESS=1, Purism Librem 13 v1 remains identical.
Change-Id: I7f87085c70149d02c544e2d43e1bdb58c7502d6d Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/auron/dsdt.asl M src/mainboard/google/jecht/dsdt.asl M src/mainboard/intel/wtm2/dsdt.asl M src/mainboard/purism/librem_bdw/dsdt.asl R src/soc/intel/broadwell/pch/acpi/adsp.asl R src/soc/intel/broadwell/pch/acpi/device_nvs.asl R src/soc/intel/broadwell/pch/acpi/ehci.asl R src/soc/intel/broadwell/pch/acpi/globalnvs.asl R src/soc/intel/broadwell/pch/acpi/gpio.asl R src/soc/intel/broadwell/pch/acpi/hda.asl R src/soc/intel/broadwell/pch/acpi/irqlinks.asl R src/soc/intel/broadwell/pch/acpi/lpc.asl R src/soc/intel/broadwell/pch/acpi/pch.asl R src/soc/intel/broadwell/pch/acpi/pcie.asl R src/soc/intel/broadwell/pch/acpi/pcie_port.asl R src/soc/intel/broadwell/pch/acpi/sata.asl R src/soc/intel/broadwell/pch/acpi/serialio.asl R src/soc/intel/broadwell/pch/acpi/smbus.asl R src/soc/intel/broadwell/pch/acpi/xhci.asl 19 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/46754/1
diff --git a/src/mainboard/google/auron/dsdt.asl b/src/mainboard/google/auron/dsdt.asl index 32c71de..a61a669 100644 --- a/src/mainboard/google/auron/dsdt.asl +++ b/src/mainboard/google/auron/dsdt.asl @@ -16,7 +16,7 @@ #include "acpi/thermal.asl"
// global NVS and variables - #include <soc/intel/broadwell/acpi/globalnvs.asl> + #include <soc/intel/broadwell/pch/acpi/globalnvs.asl>
// CPU #include <cpu/intel/common/acpi/cpu.asl> @@ -25,7 +25,7 @@ Device (PCI0) { #include <soc/intel/broadwell/acpi/systemagent.asl> - #include <soc/intel/broadwell/acpi/pch.asl> + #include <soc/intel/broadwell/pch/acpi/pch.asl> #include <drivers/intel/gma/acpi/default_brightness_levels.asl> } } diff --git a/src/mainboard/google/jecht/dsdt.asl b/src/mainboard/google/jecht/dsdt.asl index 3746d4b..6af99b4 100644 --- a/src/mainboard/google/jecht/dsdt.asl +++ b/src/mainboard/google/jecht/dsdt.asl @@ -17,7 +17,7 @@ #include <variant/acpi/thermal.asl>
// global NVS and variables - #include <soc/intel/broadwell/acpi/globalnvs.asl> + #include <soc/intel/broadwell/pch/acpi/globalnvs.asl>
// CPU #include <cpu/intel/common/acpi/cpu.asl> @@ -26,7 +26,7 @@ Device (PCI0) { #include <soc/intel/broadwell/acpi/systemagent.asl> - #include <soc/intel/broadwell/acpi/pch.asl> + #include <soc/intel/broadwell/pch/acpi/pch.asl> } }
diff --git a/src/mainboard/intel/wtm2/dsdt.asl b/src/mainboard/intel/wtm2/dsdt.asl index b3b2ca6..c842e8b 100644 --- a/src/mainboard/intel/wtm2/dsdt.asl +++ b/src/mainboard/intel/wtm2/dsdt.asl @@ -17,7 +17,7 @@ #include "acpi/platform.asl"
// global NVS and variables - #include <soc/intel/broadwell/acpi/globalnvs.asl> + #include <soc/intel/broadwell/pch/acpi/globalnvs.asl>
// CPU #include <cpu/intel/common/acpi/cpu.asl> @@ -26,7 +26,7 @@ Device (PCI0) { #include <soc/intel/broadwell/acpi/systemagent.asl> - #include <soc/intel/broadwell/acpi/pch.asl> + #include <soc/intel/broadwell/pch/acpi/pch.asl> } }
diff --git a/src/mainboard/purism/librem_bdw/dsdt.asl b/src/mainboard/purism/librem_bdw/dsdt.asl index 4d81e15..a4b5bd8 100644 --- a/src/mainboard/purism/librem_bdw/dsdt.asl +++ b/src/mainboard/purism/librem_bdw/dsdt.asl @@ -13,7 +13,7 @@ #include <soc/intel/broadwell/acpi/platform.asl>
/* Global NVS and variables */ - #include <soc/intel/broadwell/acpi/globalnvs.asl> + #include <soc/intel/broadwell/pch/acpi/globalnvs.asl>
/* CPU */ #include <cpu/intel/common/acpi/cpu.asl> @@ -22,7 +22,7 @@ Device (PCI0) { #include <soc/intel/broadwell/acpi/systemagent.asl> - #include <soc/intel/broadwell/acpi/pch.asl> + #include <soc/intel/broadwell/pch/acpi/pch.asl> } }
diff --git a/src/soc/intel/broadwell/acpi/adsp.asl b/src/soc/intel/broadwell/pch/acpi/adsp.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/adsp.asl rename to src/soc/intel/broadwell/pch/acpi/adsp.asl diff --git a/src/soc/intel/broadwell/acpi/device_nvs.asl b/src/soc/intel/broadwell/pch/acpi/device_nvs.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/device_nvs.asl rename to src/soc/intel/broadwell/pch/acpi/device_nvs.asl diff --git a/src/soc/intel/broadwell/acpi/ehci.asl b/src/soc/intel/broadwell/pch/acpi/ehci.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/ehci.asl rename to src/soc/intel/broadwell/pch/acpi/ehci.asl diff --git a/src/soc/intel/broadwell/acpi/globalnvs.asl b/src/soc/intel/broadwell/pch/acpi/globalnvs.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/globalnvs.asl rename to src/soc/intel/broadwell/pch/acpi/globalnvs.asl diff --git a/src/soc/intel/broadwell/acpi/gpio.asl b/src/soc/intel/broadwell/pch/acpi/gpio.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/gpio.asl rename to src/soc/intel/broadwell/pch/acpi/gpio.asl diff --git a/src/soc/intel/broadwell/acpi/hda.asl b/src/soc/intel/broadwell/pch/acpi/hda.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/hda.asl rename to src/soc/intel/broadwell/pch/acpi/hda.asl diff --git a/src/soc/intel/broadwell/acpi/irqlinks.asl b/src/soc/intel/broadwell/pch/acpi/irqlinks.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/irqlinks.asl rename to src/soc/intel/broadwell/pch/acpi/irqlinks.asl diff --git a/src/soc/intel/broadwell/acpi/lpc.asl b/src/soc/intel/broadwell/pch/acpi/lpc.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/lpc.asl rename to src/soc/intel/broadwell/pch/acpi/lpc.asl diff --git a/src/soc/intel/broadwell/acpi/pch.asl b/src/soc/intel/broadwell/pch/acpi/pch.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/pch.asl rename to src/soc/intel/broadwell/pch/acpi/pch.asl diff --git a/src/soc/intel/broadwell/acpi/pcie.asl b/src/soc/intel/broadwell/pch/acpi/pcie.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/pcie.asl rename to src/soc/intel/broadwell/pch/acpi/pcie.asl diff --git a/src/soc/intel/broadwell/acpi/pcie_port.asl b/src/soc/intel/broadwell/pch/acpi/pcie_port.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/pcie_port.asl rename to src/soc/intel/broadwell/pch/acpi/pcie_port.asl diff --git a/src/soc/intel/broadwell/acpi/sata.asl b/src/soc/intel/broadwell/pch/acpi/sata.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/sata.asl rename to src/soc/intel/broadwell/pch/acpi/sata.asl diff --git a/src/soc/intel/broadwell/acpi/serialio.asl b/src/soc/intel/broadwell/pch/acpi/serialio.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/serialio.asl rename to src/soc/intel/broadwell/pch/acpi/serialio.asl diff --git a/src/soc/intel/broadwell/acpi/smbus.asl b/src/soc/intel/broadwell/pch/acpi/smbus.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/smbus.asl rename to src/soc/intel/broadwell/pch/acpi/smbus.asl diff --git a/src/soc/intel/broadwell/acpi/xhci.asl b/src/soc/intel/broadwell/pch/acpi/xhci.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/xhci.asl rename to src/soc/intel/broadwell/pch/acpi/xhci.asl
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46754
to look at the new patch set (#2).
Change subject: soc/intel/broadwell: Relocate PCH ACPI files ......................................................................
soc/intel/broadwell: Relocate PCH ACPI files
Tested with BUILD_TIMELESS=1, Purism Librem 13 v1 remains identical.
Change-Id: I7f87085c70149d02c544e2d43e1bdb58c7502d6d Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/auron/dsdt.asl M src/mainboard/google/jecht/dsdt.asl M src/mainboard/intel/wtm2/dsdt.asl M src/mainboard/purism/librem_bdw/dsdt.asl R src/soc/intel/broadwell/pch/acpi/adsp.asl R src/soc/intel/broadwell/pch/acpi/device_nvs.asl R src/soc/intel/broadwell/pch/acpi/ehci.asl R src/soc/intel/broadwell/pch/acpi/globalnvs.asl R src/soc/intel/broadwell/pch/acpi/gpio.asl R src/soc/intel/broadwell/pch/acpi/hda.asl R src/soc/intel/broadwell/pch/acpi/irqlinks.asl R src/soc/intel/broadwell/pch/acpi/lpc.asl R src/soc/intel/broadwell/pch/acpi/pch.asl R src/soc/intel/broadwell/pch/acpi/pcie.asl R src/soc/intel/broadwell/pch/acpi/pcie_port.asl R src/soc/intel/broadwell/pch/acpi/sata.asl R src/soc/intel/broadwell/pch/acpi/serialio.asl R src/soc/intel/broadwell/pch/acpi/smbus.asl R src/soc/intel/broadwell/pch/acpi/xhci.asl 19 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/46754/2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46754 )
Change subject: soc/intel/broadwell: Relocate PCH ACPI files ......................................................................
Patch Set 7: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46754 )
Change subject: soc/intel/broadwell: Relocate PCH ACPI files ......................................................................
soc/intel/broadwell: Relocate PCH ACPI files
Tested with BUILD_TIMELESS=1, Purism Librem 13 v1 remains identical.
Change-Id: I7f87085c70149d02c544e2d43e1bdb58c7502d6d Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46754 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/auron/dsdt.asl M src/mainboard/google/jecht/dsdt.asl M src/mainboard/intel/wtm2/dsdt.asl M src/mainboard/purism/librem_bdw/dsdt.asl R src/soc/intel/broadwell/pch/acpi/adsp.asl R src/soc/intel/broadwell/pch/acpi/device_nvs.asl R src/soc/intel/broadwell/pch/acpi/ehci.asl R src/soc/intel/broadwell/pch/acpi/globalnvs.asl R src/soc/intel/broadwell/pch/acpi/gpio.asl R src/soc/intel/broadwell/pch/acpi/hda.asl R src/soc/intel/broadwell/pch/acpi/irqlinks.asl R src/soc/intel/broadwell/pch/acpi/lpc.asl R src/soc/intel/broadwell/pch/acpi/pch.asl R src/soc/intel/broadwell/pch/acpi/pcie.asl R src/soc/intel/broadwell/pch/acpi/pcie_port.asl R src/soc/intel/broadwell/pch/acpi/sata.asl R src/soc/intel/broadwell/pch/acpi/serialio.asl R src/soc/intel/broadwell/pch/acpi/smbus.asl R src/soc/intel/broadwell/pch/acpi/xhci.asl 19 files changed, 8 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/google/auron/dsdt.asl b/src/mainboard/google/auron/dsdt.asl index 32c71de..a61a669 100644 --- a/src/mainboard/google/auron/dsdt.asl +++ b/src/mainboard/google/auron/dsdt.asl @@ -16,7 +16,7 @@ #include "acpi/thermal.asl"
// global NVS and variables - #include <soc/intel/broadwell/acpi/globalnvs.asl> + #include <soc/intel/broadwell/pch/acpi/globalnvs.asl>
// CPU #include <cpu/intel/common/acpi/cpu.asl> @@ -25,7 +25,7 @@ Device (PCI0) { #include <soc/intel/broadwell/acpi/systemagent.asl> - #include <soc/intel/broadwell/acpi/pch.asl> + #include <soc/intel/broadwell/pch/acpi/pch.asl> #include <drivers/intel/gma/acpi/default_brightness_levels.asl> } } diff --git a/src/mainboard/google/jecht/dsdt.asl b/src/mainboard/google/jecht/dsdt.asl index 3746d4b..6af99b4 100644 --- a/src/mainboard/google/jecht/dsdt.asl +++ b/src/mainboard/google/jecht/dsdt.asl @@ -17,7 +17,7 @@ #include <variant/acpi/thermal.asl>
// global NVS and variables - #include <soc/intel/broadwell/acpi/globalnvs.asl> + #include <soc/intel/broadwell/pch/acpi/globalnvs.asl>
// CPU #include <cpu/intel/common/acpi/cpu.asl> @@ -26,7 +26,7 @@ Device (PCI0) { #include <soc/intel/broadwell/acpi/systemagent.asl> - #include <soc/intel/broadwell/acpi/pch.asl> + #include <soc/intel/broadwell/pch/acpi/pch.asl> } }
diff --git a/src/mainboard/intel/wtm2/dsdt.asl b/src/mainboard/intel/wtm2/dsdt.asl index b3b2ca6..c842e8b 100644 --- a/src/mainboard/intel/wtm2/dsdt.asl +++ b/src/mainboard/intel/wtm2/dsdt.asl @@ -17,7 +17,7 @@ #include "acpi/platform.asl"
// global NVS and variables - #include <soc/intel/broadwell/acpi/globalnvs.asl> + #include <soc/intel/broadwell/pch/acpi/globalnvs.asl>
// CPU #include <cpu/intel/common/acpi/cpu.asl> @@ -26,7 +26,7 @@ Device (PCI0) { #include <soc/intel/broadwell/acpi/systemagent.asl> - #include <soc/intel/broadwell/acpi/pch.asl> + #include <soc/intel/broadwell/pch/acpi/pch.asl> } }
diff --git a/src/mainboard/purism/librem_bdw/dsdt.asl b/src/mainboard/purism/librem_bdw/dsdt.asl index 4d81e15..a4b5bd8 100644 --- a/src/mainboard/purism/librem_bdw/dsdt.asl +++ b/src/mainboard/purism/librem_bdw/dsdt.asl @@ -13,7 +13,7 @@ #include <soc/intel/broadwell/acpi/platform.asl>
/* Global NVS and variables */ - #include <soc/intel/broadwell/acpi/globalnvs.asl> + #include <soc/intel/broadwell/pch/acpi/globalnvs.asl>
/* CPU */ #include <cpu/intel/common/acpi/cpu.asl> @@ -22,7 +22,7 @@ Device (PCI0) { #include <soc/intel/broadwell/acpi/systemagent.asl> - #include <soc/intel/broadwell/acpi/pch.asl> + #include <soc/intel/broadwell/pch/acpi/pch.asl> } }
diff --git a/src/soc/intel/broadwell/acpi/adsp.asl b/src/soc/intel/broadwell/pch/acpi/adsp.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/adsp.asl rename to src/soc/intel/broadwell/pch/acpi/adsp.asl diff --git a/src/soc/intel/broadwell/acpi/device_nvs.asl b/src/soc/intel/broadwell/pch/acpi/device_nvs.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/device_nvs.asl rename to src/soc/intel/broadwell/pch/acpi/device_nvs.asl diff --git a/src/soc/intel/broadwell/acpi/ehci.asl b/src/soc/intel/broadwell/pch/acpi/ehci.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/ehci.asl rename to src/soc/intel/broadwell/pch/acpi/ehci.asl diff --git a/src/soc/intel/broadwell/acpi/globalnvs.asl b/src/soc/intel/broadwell/pch/acpi/globalnvs.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/globalnvs.asl rename to src/soc/intel/broadwell/pch/acpi/globalnvs.asl diff --git a/src/soc/intel/broadwell/acpi/gpio.asl b/src/soc/intel/broadwell/pch/acpi/gpio.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/gpio.asl rename to src/soc/intel/broadwell/pch/acpi/gpio.asl diff --git a/src/soc/intel/broadwell/acpi/hda.asl b/src/soc/intel/broadwell/pch/acpi/hda.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/hda.asl rename to src/soc/intel/broadwell/pch/acpi/hda.asl diff --git a/src/soc/intel/broadwell/acpi/irqlinks.asl b/src/soc/intel/broadwell/pch/acpi/irqlinks.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/irqlinks.asl rename to src/soc/intel/broadwell/pch/acpi/irqlinks.asl diff --git a/src/soc/intel/broadwell/acpi/lpc.asl b/src/soc/intel/broadwell/pch/acpi/lpc.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/lpc.asl rename to src/soc/intel/broadwell/pch/acpi/lpc.asl diff --git a/src/soc/intel/broadwell/acpi/pch.asl b/src/soc/intel/broadwell/pch/acpi/pch.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/pch.asl rename to src/soc/intel/broadwell/pch/acpi/pch.asl diff --git a/src/soc/intel/broadwell/acpi/pcie.asl b/src/soc/intel/broadwell/pch/acpi/pcie.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/pcie.asl rename to src/soc/intel/broadwell/pch/acpi/pcie.asl diff --git a/src/soc/intel/broadwell/acpi/pcie_port.asl b/src/soc/intel/broadwell/pch/acpi/pcie_port.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/pcie_port.asl rename to src/soc/intel/broadwell/pch/acpi/pcie_port.asl diff --git a/src/soc/intel/broadwell/acpi/sata.asl b/src/soc/intel/broadwell/pch/acpi/sata.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/sata.asl rename to src/soc/intel/broadwell/pch/acpi/sata.asl diff --git a/src/soc/intel/broadwell/acpi/serialio.asl b/src/soc/intel/broadwell/pch/acpi/serialio.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/serialio.asl rename to src/soc/intel/broadwell/pch/acpi/serialio.asl diff --git a/src/soc/intel/broadwell/acpi/smbus.asl b/src/soc/intel/broadwell/pch/acpi/smbus.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/smbus.asl rename to src/soc/intel/broadwell/pch/acpi/smbus.asl diff --git a/src/soc/intel/broadwell/acpi/xhci.asl b/src/soc/intel/broadwell/pch/acpi/xhci.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/xhci.asl rename to src/soc/intel/broadwell/pch/acpi/xhci.asl
-
Angel Pons (Code Review) -
Michael Niewöhner (Code Review)