[S] Change in coreboot[main]: cpu/x86: Conditionally invalidate caches based on self-snooping support

[Subrata Banik (Code Review)]

Attention is currently required from: Jérémy Compostella, Shuo Liu.

Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87182?usp=email )

Change subject: cpu/x86: Conditionally invalidate caches based on self-snooping support
......................................................................

Patch Set 2:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/87182/comment/54d9e06d_28a9c136?usp... :
PS2, Line 35:
> Does arch_segment_loaded in cpu/x86/cache/cache.c needs to be handled as well?

I thought I had added that already ? in not then I don't see that being called outside the CAR phase.

File src/cpu/x86/mp_init.c:

https://review.coreboot.org/c/coreboot/+/87182/comment/9e6800ba_d99ba211?usp... :
PS2, Line 831: 	if (!self_snooping_supported()) {
> Do we need to check clflush_supported to do clflush over wbinvd?

good idea but that would be anyway a separate CL and shouldn't be in this CL's scope. isn't it ?