Julius Werner has posted comments on this change. ( https://review.coreboot.org/19770 )
Change subject: soc/mediatek/mt8173: Move spi driver to use spi_bus_map ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/19770/3/src/soc/mediatek/mt8173/spi.c File src/soc/mediatek/mt8173/spi.c:
Line 305: .max_xfer_size = 65535, Actually all of the above don't matter anyway because it's a programmer-speicfic probe that will overwrite read/write/erase directly. Some of them (e.g. claim/release) are completely wrong and would do bad things if they ever actually got called. Maybe better to leave them NULL?