Attention is currently required from: Lance Zhao, Konrad Adamczyk, Jakub Czapiga, Grzegorz Bernacki, Tim Van Patten, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74715 )
Change subject: acpi: Add missing cbfs_unmap() ......................................................................
Patch Set 3:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/74715/comment/f4309008_d6063981 PS2, Line 1934: cbfs_unmap(dsdt_file);
Beyond the scope of this change, I wonder if we can make mem_pool library flexible by freeing the […]
Is that extra complexity really necessary though? The entire heap region just ends up in CBMEM and thus is reserved memory unavailable to the OS. As long as you don't overflow your heap, there aren't any problems with this approach. This is why free() is only used when you know you can reclaim; it uses the same approach of only being able to free the last allocation made. Unless you come up with some new algorithm that creates a lot of heap-allocated temporaries that need to be freed and you would exhaust your heap region, I argue leave things as they are.
-
Tim Wawrzynczak (Code Review)