Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83248?usp=email )
(
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/volteer/baseboard: Drop disabled SATA settings from dt ......................................................................
mb/google/volteer/baseboard: Drop disabled SATA settings from dt
Configuring them to 0 is equal to not configuring them at all. So remove them to clean up a bit.
Change-Id: I18134ac784fffb703e1fe513e5914f05faa749c9 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/83248 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index fe13b77..5df3947 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -143,9 +143,7 @@
# Enable SATA register "SataSalpSupport" = "1" - register "SataPortsEnable[0]" = "0" register "SataPortsEnable[1]" = "1" - register "SataPortsDevSlp[0]" = "0" register "SataPortsDevSlp[1]" = "1" register "SataPortsEnableDitoConfig[1]" = "1"