Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82100?usp=email )
Change subject: mb/google/brya/var/xol: Tune I2C5 timing parameters ......................................................................
Patch Set 2:
(4 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/82100/comment/4ef23873_ee26eac7 : PS1, Line 7: Update I2C5 timing parameter
Maybe more specific: Tune I2C5 timings for touchpad spec
It's just for I2C bus spec, I think we don't need specify for general tuning.
https://review.coreboot.org/c/coreboot/+/82100/comment/041c6060_cff1f5ef : PS1, Line 9: touchpad spec
Please add the name and revision.
Sorry, it's I2C bus spec.
https://review.coreboot.org/c/coreboot/+/82100/comment/d6006c55_4c8fc55b : PS1, Line 10:
What were the values before, and what does the spec require?
Done
File src/mainboard/google/brya/variants/xol/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/82100/comment/37db5291_78c43a0a : PS1, Line 136: .data_hold_time_ns = 50,
What is the default?
Got further tuning value. Thanks for the review.