Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/57218 )
Change subject: soc/amd/common/fsp/Makefile: drop strip_quotes call in FSP-M size check ......................................................................
soc/amd/common/fsp/Makefile: drop strip_quotes call in FSP-M size check
No need to strip the quotes of the FSP-M file path in the size check and it's always a good idea to not remove the quotes around file paths that will get passed as parameters to shell programs so that spaces in the path can't cause malfunction.
TEST=All cases still behave as expected for Mandolin.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Suggested-by: Nico Huber nico.h@gmx.de Change-Id: Ieeea84b5861f9d15b2472208432169dc8e3f0049 Reviewed-on: https://review.coreboot.org/c/coreboot/+/57218 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/soc/amd/common/fsp/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/soc/amd/common/fsp/Makefile.inc b/src/soc/amd/common/fsp/Makefile.inc index ee5e1ac..eac9e06 100644 --- a/src/soc/amd/common/fsp/Makefile.inc +++ b/src/soc/amd/common/fsp/Makefile.inc @@ -11,7 +11,7 @@ $(info There's no FSP-M binary file specified. The resulting image won't boot successfully.) else ifeq ($(call int-gt,\ - $(call file-size,$(call strip_quotes,$(CONFIG_FSP_M_FILE)))\ + $(call file-size,$(CONFIG_FSP_M_FILE))\ $(shell printf "%d" $(CONFIG_FSP_M_SIZE))),\ 1) $(error FSP-M binary larger than FSP_M_FILE.)