Attention is currently required from: Eric Lai, Ivan Chen, Kapil Porwal, Matt DeVillier, Nick Vaccaro, Paul Menzel, Subrata Banik.
Hello Derek Huang, Eric Lai, Ivan Chen, Kapil Porwal, Matt DeVillier, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80769?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review-1 by Matt DeVillier, Verified+1 by build bot (Jenkins)
Change subject: mb/google/brya/var/omniknight: remove Implement touchscreen power sequencing
......................................................................
mb/google/brya/var/omniknight: remove Implement touchscreen power sequencing
For TP_EN has a abnormal peek pull high before BL_EN.
Because power sequence no meet spec, pre #comment36, it may have ghost touch.
BUG=b:326337003
TEST=FW_NAME=omnigul emerge-brya coreboot and measurement of HW
Change-Id: I66f4a7915f135927fbc0a16254dece202dfc23a2
Signed-off-by: Jamie Chen jamie_chen@compal.corp-partner.google.com
---
M src/mainboard/google/brya/variants/omnigul/gpio.c
M src/mainboard/google/brya/variants/omnigul/overridetree.cb
2 files changed, 3 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/80769/6
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80769?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I66f4a7915f135927fbc0a16254dece202dfc23a2
Gerrit-Change-Number: 80769
Gerrit-PatchSet: 6
Gerrit-Owner: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Ivan Chen
yulunchen@google.com
Gerrit-MessageType: newpatchset