Attention is currently required from: Bora Guvendik, Cliff Huang, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Kyoung Il Kim, Paul Menzel, Pranava Y N, Subrata Banik, Wonkyu Kim.
Jérémy Compostella has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/85199?usp=email )
Change subject: soc/intel/pantherlake: Add Touch Controller UPD and SoC config ......................................................................
Patch Set 34:
(2 comments)
File src/soc/intel/pantherlake/chip.h:
https://review.coreboot.org/c/coreboot/+/85199/comment/2d1f269e_fc02b0d7?usp... : PS34, Line 547: 2 Would it make sense to have a `NUM_THC_DEV` (or another name). We could also use that maybe in fsp_params.c
File src/soc/intel/pantherlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/85199/comment/4b2bc071_9500d49b?usp... : PS34, Line 578: if (is_devfn_enabled(PCI_DEVFN_THC0)) { : s_cfg->ThcAssignment[0] = THC_0; : s_cfg->ThcMode[0] = config->thc_mode[0]; : s_cfg->ThcWakeOnTouch[0] = config->thc_wake_on_touch[0]; : } else { : s_cfg->ThcAssignment[0] = THC_NONE; : } : : if (is_devfn_enabled(PCI_DEVFN_THC1)) { : s_cfg->ThcAssignment[1] = THC_1; : s_cfg->ThcMode[1] = config->thc_mode[1]; : s_cfg->ThcWakeOnTouch[1] = config->thc_wake_on_touch[1]; : } else { : s_cfg->ThcAssignment[1] = THC_NONE; : } What about something like: ``` for (size_t i = 0; i < NUM_THC_DEV; i++) { if (!is_devfn_enabled(_PCI_DEVFN(THC, i))) { s_cfg->ThcAssignment[i] = THC_NONE; continue; }
s_cfg->ThcAssignment[i] = THC_0 + i; s_cfg->ThcMode[i] = config->thc_mode[i]; s_cfg->ThcWakeOnTouch[i] = config->thc_wake_on_touch[i]; }
```