Change in coreboot[master]: intel/fsp2_0: Add weak function soc_fsp_get_version for SoC override
Johnny Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47603 )
Change subject: intel/fsp2_0: Add weak function soc_fsp_get_version for SoC override ......................................................................
intel/fsp2_0: Add weak function soc_fsp_get_version for SoC override
SoC can implement their own FSP version format and add to coreboot table LB_TAG_PLATFORM_BLOB_VERSION.
Change-Id: I8d2427b7f7a2da9e8fe68e1494a2398b12802adc Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/drivers/intel/fsp2_0/include/fsp/util.h M src/drivers/intel/fsp2_0/util.c 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/47603/1
diff --git a/src/drivers/intel/fsp2_0/include/fsp/util.h b/src/drivers/intel/fsp2_0/include/fsp/util.h index 315db05..7e6eede 100644 --- a/src/drivers/intel/fsp2_0/include/fsp/util.h +++ b/src/drivers/intel/fsp2_0/include/fsp/util.h @@ -97,7 +97,7 @@ const struct hob_header *fsp_next_hob(const struct hob_header *parent); bool fsp_guid_compare(const uint8_t guid1[16], const uint8_t guid2[16]); void fsp_find_bootloader_tolum(struct range_entry *re); -void fsp_get_version(char *buf); +void soc_fsp_get_version(char *buf); void lb_string_platform_blob_version(struct lb_header *header); void report_fspt_output(void); void soc_validate_fsp_version(const struct fsp_header *hdr); diff --git a/src/drivers/intel/fsp2_0/util.c b/src/drivers/intel/fsp2_0/util.c index 490816d..cf5583b 100644 --- a/src/drivers/intel/fsp2_0/util.c +++ b/src/drivers/intel/fsp2_0/util.c @@ -213,7 +213,7 @@ }
/* Only call this function when FSP header has been read and validated */ -void fsp_get_version(char *buf) +__weak void soc_fsp_get_version(char *buf) { struct fsp_header *hdr = &fsps_hdr; union fsp_revision revision; @@ -231,7 +231,7 @@ size_t len; char fsp_version[FSP_VER_LEN] = {0};
- fsp_get_version(fsp_version); + soc_fsp_get_version(fsp_version); rec = (struct lb_string *)lb_new_record(header); rec->tag = LB_TAG_PLATFORM_BLOB_VERSION; len = strlen(fsp_version);
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47603 )
Change subject: intel/fsp2_0: Add weak function soc_fsp_get_version for SoC override ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47603/1/src/drivers/intel/fsp2_0/ut... File src/drivers/intel/fsp2_0/util.c:
https://review.coreboot.org/c/coreboot/+/47603/1/src/drivers/intel/fsp2_0/ut... PS1, Line 220: Uh, since the only change that is needed is to have the `bld_num` field split in two for some FSP versions, why not introduce a Kconfig option FSP_BUILD_VERSION_FORMAT_WORK_WEEK and place a simple check in here?
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47603 )
Change subject: intel/fsp2_0: Add weak function soc_fsp_get_version for SoC override ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47603/1/src/drivers/intel/fsp2_0/ut... File src/drivers/intel/fsp2_0/util.c:
https://review.coreboot.org/c/coreboot/+/47603/1/src/drivers/intel/fsp2_0/ut... PS1, Line 220:
Uh, since the only change that is needed is to have the `bld_num` field split in two for some FSP ve […]
Intel server FSP team has not come up with a process/design for versioning and release. My predication is that it will be volatile for some time. So I am not sure if adding a Kconfig is a good idea. How are other FSPs versioned?
Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47603 )
Change subject: intel/fsp2_0: Add weak function soc_fsp_get_version for SoC override ......................................................................
Patch Set 1:
fsp_version.c didn't get added to the patch.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47603 )
Change subject: intel/fsp2_0: Add weak function soc_fsp_get_version for SoC override ......................................................................
Patch Set 1:
Patch Set 1:
fsp_version.c didn't get added to the patch.
I add the override function in CB:47560
Johnny Lin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47603 )
Change subject: intel/fsp2_0: Add weak function soc_fsp_get_version for SoC override ......................................................................
Abandoned
-
Angel Pons (Code Review) -
Johnny Lin (Code Review)
-
Jonathan Zhang (Code Review)
-
Marc Jones (Code Review)