Change in coreboot[master]: mb/google/octopus: disable fmap cache for all octopus devices
Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37163 )
Change subject: mb/google/octopus: disable fmap cache for all octopus devices ......................................................................
mb/google/octopus: disable fmap cache for all octopus devices
Meep was just the first one to fail, but the others aren't any better.
Change-Id: I177c50cfe7593a5b2ad770ce1ab1191d2dff93d2 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/google/octopus/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/37163/1
diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index d712600..ef61499 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -22,7 +22,7 @@ select MAINBOARD_HAS_SPI_TPM_CR50 select MAINBOARD_HAS_TPM2 select GOOGLE_SMBIOS_MAINBOARD_VERSION - select NO_FMAP_CACHE if BOARD_GOOGLE_MEEP + select NO_FMAP_CACHE
if BOARD_GOOGLE_BASEBOARD_OCTOPUS
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37163 )
Change subject: mb/google/octopus: disable fmap cache for all octopus devices ......................................................................
Patch Set 1: Code-Review+2
What is the size increase/decrease actually?
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37163 )
Change subject: mb/google/octopus: disable fmap cache for all octopus devices ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
What is the size increase/decrease actually?
500-600 bytes
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37163 )
Change subject: mb/google/octopus: disable fmap cache for all octopus devices ......................................................................
mb/google/octopus: disable fmap cache for all octopus devices
Meep was just the first one to fail, but the others aren't any better.
Change-Id: I177c50cfe7593a5b2ad770ce1ab1191d2dff93d2 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37163 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index 1177cd5..65a641b 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -22,7 +22,7 @@ select MAINBOARD_HAS_SPI_TPM_CR50 select MAINBOARD_HAS_TPM2 select GOOGLE_SMBIOS_MAINBOARD_VERSION - select NO_FMAP_CACHE if BOARD_GOOGLE_MEEP + select NO_FMAP_CACHE
if BOARD_GOOGLE_BASEBOARD_OCTOPUS
-
Arthur Heymans (Code Review) -
Patrick Georgi (Code Review)