Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45208 )
Change subject: console: Allow VPD to disable an otherwise enabled coreboot console
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45208/4/src/console/init.c
File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/45208/4/src/console/init.c@41
PS4, Line 41: vpd_get_bool
Will this fall over if we use printk in the bootblock on ARM without setting up the SPI controller?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45208
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f1f5c45e5ea889176d04e0db438ca2aa7c536ee
Gerrit-Change-Number: 45208
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Greg Edelston
gredelston@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Mon, 02 Nov 2020 22:52:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment