Attention is currently required from: Tarun Tuli, Ren Kuo, Matthew Ziegelbaum, Nick Vaccaro, Pablo Ceballos, Morris Hsu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72775 )
Change subject: mb/google/brya/var/constitution: Add SOLDERDOWN support
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/variants/constitution/memory/mem_parts_used.txt:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169869):
https://review.coreboot.org/c/coreboot/+/72775/comment/a2419002_cc792765
PS4, Line 9: # See util/spd_tools/README.md for more details and instructions.
'README' may be misspelled - perhaps 'README'?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72775
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id879b2a7491f29e9fca903dcf3c022ec8ffffab4
Gerrit-Change-Number: 72775
Gerrit-PatchSet: 4
Gerrit-Owner: Morris Hsu
morris-hsu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Matthew Ziegelbaum
ziegs@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Pablo Ceballos
pceballos@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Matthew Ziegelbaum
ziegs@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Pablo Ceballos
pceballos@google.com
Gerrit-Attention: Morris Hsu
morris-hsu@quanta.corp-partner.google.com
Gerrit-Comment-Date: Sat, 04 Feb 2023 06:31:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment