Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52533 )
Change subject: commonlib/region: Turn addrspace_32bit into a more official API
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52533/comment/94f78788_3bd21c15
PS1, Line 15: 32 bits in 64-bit environments
Oh right I guess it was written that way... […]
Most *nix systems use lp64 vs llp64 (windows). However, it's totally up to how people decide to define ABI.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52533
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4c763b77f77d227768556a9528681d771a08dca
Gerrit-Change-Number: 52533
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Wed, 21 Apr 2021 14:12:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment