Change in coreboot[master]: acpi: Add support for reporting CrashLog in BERT table.

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Lance Zhao, Francois Toguo Fotso, Martin Roth, Nikunj Dadhania, Tim Wawrzynczak, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49799 )

Change subject: acpi: Add support for reporting CrashLog in BERT table.
......................................................................

Patch Set 7: Code-Review+1

(5 comments)

Patchset:

PS5:
> The code looks sounds but I guess it would be useful to see how all this is used. […]

It shouldn't be a "per-SoC return false/true" thing, because the implementation for TGL depends on whether the Crashlog device detected any errors to report or not, so it could be different per-boot.

Patchset:

PS7: 
Looks pretty good, Francois, thank you!

just a few minor nits

File src/arch/x86/acpi_bert_storage.c:

https://review.coreboot.org/c/coreboot/+/49799/comment/a585f9f0_55e6da50 
PS7, Line 229: 2
Is this defined somewhere already? If not, would you mind adding a `#define` for this?

https://review.coreboot.org/c/coreboot/+/49799/comment/e10a8a2b_11619afd 
PS7, Line 229: recort
record

https://review.coreboot.org/c/coreboot/+/49799/comment/dc232553_c535b3d2 
PS7, Line 230: 2
same here