Change in coreboot[master]: nb/intel/nehalem: Fix typo

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

7 Jan 2020 7 Jan '20

7:25 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38246 )

Change subject: nb/intel/nehalem: Fix typo ......................................................................

nb/intel/nehalem: Fix typo

Change-Id: If4b47ccef2f0aa5396b6add5ab2f768b36b2ab5c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/nehalem/raminit.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/38246/1

diff --git a/src/northbridge/intel/nehalem/raminit.c b/src/northbridge/intel/nehalem/raminit.c index 215e9b8..ae51b4a 100644 --- a/src/northbridge/intel/nehalem/raminit.c +++ b/src/northbridge/intel/nehalem/raminit.c @@ -1509,7 +1509,7 @@ else gav(info->uma_enabled = pci_read_config8(NORTHBRIDGE, D0F0_DEVEN) & 8); - /* Unrecognised: [0000:fffd3d2d] 37f81.37f82 ! CPUID: eax: 00000001; ecx: 00000e00 => 00020655.00010800.029ae3ff.bfebfbff */ + /* Unrecognized: [0000:fffd3d2d] 37f81.37f82 ! CPUID: eax: 00000001; ecx: 00000e00 => 00020655.00010800.029ae3ff.bfebfbff */ info->silicon_revision = 0;

if (capid0[2] & 2) {

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

build bot (Jenkins) (Code Review)

7 Jan 7 Jan

7:25 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38246 )

Change subject: nb/intel/nehalem: Fix typo ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38246/1/src/northbridge/intel/nehal... File src/northbridge/intel/nehalem/raminit.c:

https://review.coreboot.org/c/coreboot/+/38246/1/src/northbridge/intel/nehal... PS1, Line 1512: /* Unrecognized: [0000:fffd3d2d] 37f81.37f82 ! CPUID: eax: 00000001; ecx: 00000e00 => 00020655.00010800.029ae3ff.bfebfbff */ line over 96 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/38246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4b47ccef2f0aa5396b6add5ab2f768b36b2ab5c Gerrit-Change-Number: 38246 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 07 Jan 2020 19:25:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

8 Jan 8 Jan

12:07 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38246 )

Change subject: nb/intel/nehalem: Fix typo ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38246/2/src/northbridge/intel/nehal... File src/northbridge/intel/nehalem/raminit.c:

https://review.coreboot.org/c/coreboot/+/38246/2/src/northbridge/intel/nehal... PS2, Line 1512: /* Unrecognized: [0000:fffd3d2d] 37f81.37f82 ! CPUID: eax: 00000001; ecx: 00000e00 => 00020655.00010800.029ae3ff.bfebfbff */ line over 96 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/38246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4b47ccef2f0aa5396b6add5ab2f768b36b2ab5c Gerrit-Change-Number: 38246 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 08 Jan 2020 12:07:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michał Żygowski (Code Review)

12:28 p.m.

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38246 )

Change subject: nb/intel/nehalem: Fix typo ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4b47ccef2f0aa5396b6add5ab2f768b36b2ab5c Gerrit-Change-Number: 38246 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 08 Jan 2020 12:28:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

12:56 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38246 )

Change subject: nb/intel/nehalem: Fix typo ......................................................................

Patch Set 2: Code-Review+1

That’s British English, I believe. If we prefer American English, that should be documented somewhere.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4b47ccef2f0aa5396b6add5ab2f768b36b2ab5c Gerrit-Change-Number: 38246 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 08 Jan 2020 12:56:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

8:01 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38246 )

Change subject: nb/intel/nehalem: Fix typo ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38246/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38246/2//COMMIT_MSG@7 PS2, Line 7: typo Um, `unrecognised` is not a typo. It's the correct spelling in British English.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4b47ccef2f0aa5396b6add5ab2f768b36b2ab5c Gerrit-Change-Number: 38246 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Wed, 08 Jan 2020 20:01:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

8:52 p.m.

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38246 )

Change subject: nb/intel/nehalem: Fix typo ......................................................................

Abandoned

unrecognised isn't a typo

-- To view, visit https://review.coreboot.org/c/coreboot/+/38246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4b47ccef2f0aa5396b6add5ab2f768b36b2ab5c Gerrit-Change-Number: 38246 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: abandon

1781

days inactive

1782

days old

coreboot-gerrit@coreboot.org

6 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
build bot (Jenkins) (Code Review)
HAOUAS Elyes (Code Review)
Michał Żygowski (Code Review)
Paul Menzel (Code Review)