HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34558 )
Change subject: nb/intel/i440bx: Remove never used 'dra' value ......................................................................
nb/intel/i440bx: Remove never used 'dra' value
Change-Id: I65c41f56d7a0639eac821844e653e5644aca4f0c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i440bx/raminit.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/34558/1
diff --git a/src/northbridge/intel/i440bx/raminit.c b/src/northbridge/intel/i440bx/raminit.c index 91959c7..3a1b66a 100644 --- a/src/northbridge/intel/i440bx/raminit.c +++ b/src/northbridge/intel/i440bx/raminit.c @@ -799,7 +799,6 @@ }
/* "DRA" is our RPS for the two rows on this DIMM. */ - dra = 0;
/* Columns */ col = spd_read_byte(device, SPD_NUM_COLUMNS);
Johanna Schander has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34558 )
Change subject: nb/intel/i440bx: Remove never used 'dra' value ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34558/1/src/northbridge/intel/i440b... File src/northbridge/intel/i440bx/raminit.c:
https://review.coreboot.org/c/coreboot/+/34558/1/src/northbridge/intel/i440b... PS1, Line 801: /* "DRA" is our RPS for the two rows on this DIMM. */ I think we should also adjust the comment
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34558 )
Change subject: nb/intel/i440bx: Remove never used 'dra' value ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Johanna Schander (Code Review)