Attention is currently required from: Sam McNally.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78294?usp=email )
Change subject: mb/google/dedede: Wait for HPD on dibbi variants
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/dedede/mainboard.c:
https://review.coreboot.org/c/coreboot/+/78294/comment/f363fe56_939b0ebf :
PS1, Line 54: printk(BIOS_WARNING, "No HPD GPIOs, skip waiting\n");
`return;`?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78294?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id4657b5d5a95a68ecbd9efcf3585cf96ad1e13e1
Gerrit-Change-Number: 78294
Gerrit-PatchSet: 2
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-CC: Derek Huang
derekhuang@google.com
Gerrit-CC: Ricky Chang
rickytlchang@google.com
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Comment-Date: Mon, 09 Oct 2023 00:25:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam McNally
sammc@google.com
Gerrit-MessageType: comment