Nico Huber has posted comments on this change. ( https://review.coreboot.org/26732 )
Change subject: src/cpu: Remove unneeded headers ......................................................................
Patch Set 2:
(10 comments)
https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_65x/model_65x_in... File src/cpu/intel/model_65x/model_65x_init.c:
https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_65x/model_65x_in... PS2, Line 17: #include <stdint.h> not used either?
https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_67x/model_67x_in... File src/cpu/intel/model_67x/model_67x_init.c:
https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_67x/model_67x_in... PS2, Line 17: #include <console/console.h> : #include <string.h> both unused?
https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_68x/model_68x_in... File src/cpu/intel/model_68x/model_68x_init.c:
https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_68x/model_68x_in... PS2, Line 20: #include <string.h> unused?
https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_69x/model_69x_in... File src/cpu/intel/model_69x/model_69x_init.c:
https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_69x/model_69x_in... PS2, Line 14: #include <console/console.h> unused?
https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_69x/model_69x_in... PS2, Line 16: #include <string.h> unused?
https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_6bx/model_6bx_in... File src/cpu/intel/model_6bx/model_6bx_init.c:
https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_6bx/model_6bx_in... PS2, Line 20: #include <string.h> unused?
https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_6dx/model_6dx_in... File src/cpu/intel/model_6dx/model_6dx_init.c:
https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_6dx/model_6dx_in... PS2, Line 14: #include <console/console.h> unused?
https://review.coreboot.org/#/c/26732/2/src/cpu/intel/model_6dx/model_6dx_in... PS2, Line 16: #include <string.h> unused?
https://review.coreboot.org/#/c/26732/2/src/cpu/intel/slot_1/l2_cache.c File src/cpu/intel/slot_1/l2_cache.c:
https://review.coreboot.org/#/c/26732/2/src/cpu/intel/slot_1/l2_cache.c@43 PS2, Line 43: #include <string.h> unused? (didn't look very close)
https://review.coreboot.org/#/c/26732/2/src/cpu/x86/tsc/delay_tsc.c File src/cpu/x86/tsc/delay_tsc.c:
https://review.coreboot.org/#/c/26732/2/src/cpu/x86/tsc/delay_tsc.c@15 PS2, Line 15: #include <console/console.h> unused?
-
Nico Huber (Code Review)