[L] Change in coreboot[master]: lib/coreboot_table: Simplify API to set up lb_serial - coreboot-gerrit

26 Oct 2022


      Attention is currently required from: Julius Werner, Arthur Heymans, ron minnich.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68768 )
Change subject: lib/coreboot_table: Simplify API to set up lb_serial
......................................................................
Patch Set 8:
(1 comment)
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/68768/comment/d76c9bf5_1d4ea314 
PS8, Line 111: else
one last concern is should we do a check/assert here, and only add LB_TAG_CONSOLE_SERIAL8250MEM console if the type is known?
(in case if some get_lb_serial returned a struct with new type of console, or if they forgot to set the type to a valid value...)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/68768
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c08a88fb5fc035eb28d0becf19471c709c8043d
Gerrit-Change-Number: 68768
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: ron minnich rminnich@gmail.com
Gerrit-Comment-Date: Wed, 26 Oct 2022 15:16:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment