Attention is currently required from: Tarun Tuli, Eran Mitrani, Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 )
Change subject: soc/intel/common, alderlake: provide a list of D-states to enter LPM ......................................................................
Patch Set 7: Code-Review+1
(6 comments)
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/70166/comment/076610c8_6799d2e4 PS7, Line 168: struct min_sleep_state min_pci_sleep_states[] = { how about marking this structure as static ?
https://review.coreboot.org/c/coreboot/+/70166/comment/b711f7f1_95a15dbc PS7, Line 233: soc_lpi_get_constraints can't we call `acpi_generate_lpi_constraint_table()` directly from pep.c file ?
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/70166/comment/55e0283f_4fe67196 PS7, Line 30: = 0 same
https://review.coreboot.org/c/coreboot/+/70166/comment/5132542d_ad2249e2 PS7, Line 31: }; please one blank line
https://review.coreboot.org/c/coreboot/+/70166/comment/5de0b548_a9713666 PS7, Line 33: LPI_DISANBLED = 0, : LPI_ENABLED = 1, nit: you can avoid assignments.
https://review.coreboot.org/c/coreboot/+/70166/comment/aeed0873_01d8075f PS7, Line 455: ar `ar` is like array ?
if yes, then u can use `arr`